This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use WeightToFee when calculating cost of each weight unit in XCM trader #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Mar 1, 2022
KiChjang
commented
Mar 1, 2022
hbulgarini
added
the
T7-system_parachains
gilescope
approved these changes
Mar 7, 2022
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #920.
We change the
Trader'sWeightToFeetype parameter to each chain'sWeightToFeestruct that properly calculates and converts weight units into fees. Previously, it would do a 1-to-1 conversion between weight units and plancks.