Deny using relay chain for reserve transfers #1169
Conversation
gilescope
requested review from
KiChjang,
NachoPal,
hbulgarini and
joepetrowski
|
DumbQ: Any action needed for the template in this PR? |
Considering that the template will be used mostly by future Parachains, I would say yes, it is a good idea to reject by default The proper way to reserve transfer funds back to the reserve is by making use of Unless somebody disagrees, can you @gilescope add also the change to the |
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Deny InitiateReserveWithdrawal
|
Has it been tested? |
|
RE testing: I've tested that attempting to do a limited reserve asset transfer on statemine/statemint leads to a failure of Barrier. I've not run up a local westmint which does not filter Execute and tried executing individual instructions but that is something we could do. |
|
So just to confirm, I've checked that we can still do teleports back and forth between the relay and statemine, and that we can do a reserve asset transfer on statemine to the community parachain wtihout it getting blocked by the barrier. |
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
| } | ||
| } | ||
|
|
||
| // See issue #5233 |
There was a problem hiding this comment.
Should be paritytech/polkadot#5233
There was a problem hiding this comment.
Thanks, meant to make a follow up PR to docs in parachain-template. Will fix this too.
Fixes #5233
I will move DenyThenTry to polkadot xcm and then reference it from there in a later release, but we'd like to ship this for v900.