Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate#14435 (BenchmarkHelper for frame-system) #2766

Merged
merged 9 commits into from
Jun 23, 2023
Merged

Companion for substrate#14435 (BenchmarkHelper for frame-system) #2766

merged 9 commits into from
Jun 23, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 21, 2023 •
edited

@bkontur bkontur added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Jun 21, 2023
@bkontur
Copy link
Contributor Author

bkontur commented Jun 21, 2023

bot bench $ pallet asset-hub-kusama assets frame_system

@command-bot
Copy link

command-bot bot commented Jun 21, 2023 •
edited

@bkontur Command was rescheduled and failed to finish (check for task id 1-c2ca62d5-4832-4d08-a05d-260546f9b709 in the logs); execution will not automatically be restarted further.

@bkontur bkontur mentioned this pull request Jun 21, 2023
Closed
@bkontur
Copy link
Contributor Author

bkontur commented Jun 21, 2023

bot bench $ pallet asset-hub-kusama assets frame_system

@command-bot
Copy link

command-bot bot commented Jun 21, 2023 •
edited

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3044226 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets frame_system. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-ef9d91e6-48b3-4309-82bb-1f5b636f3d56 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 21, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet asset-hub-kusama assets frame_system has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3044226 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3044226/artifacts/download.

@bkontur bkontur mentioned this pull request Jun 21, 2023
Merged
@bkontur bkontur mentioned this pull request Jun 21, 2023
Closed
@paritytech-ci paritytech-ci requested review from a team June 21, 2023 21:41
@bkontur bkontur changed the title Temporary fix for frame_system::set_code benchmark Companion for substrate#14435 (BenchmarkHelper for frame-system) Jun 21, 2023
rphmeier
rphmeier reviewed Jun 23, 2023
View reviewed changes
pallets/parachain-system/src/lib.rs
<ValidationData<T>>::put(&vfp);

// insert dummy HostConfiguration with
let host_config = AbridgedHostConfiguration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting all values here to zero may lead to unexpected behavior in the benchmark, if e.g. set_validation_data is called within the benchmark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thank you, changed to non-zero values

@paritytech-ci paritytech-ci requested a review from a team June 23, 2023 10:03
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 3a1b06f into master Jun 23, 2023
31 checks passed
@paritytech-processbot paritytech-processbot bot deleted the bko-fix-benchmarks branch June 23, 2023 12:34
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-43/3158/4

@hbulgarini
Copy link
Contributor

@bkontur could we backport this PR to polkadot-v0.9.43 branch? even if 0.9.43 is not the latest release there might be some teams still wanting to upgrade to this release and if they try to run the benchmarking for the frame_system pallet it will fail as it is happening in trappist: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/3430203

@wischli wischli mentioned this pull request Oct 30, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier left review comments

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bkontur @Polkadot-Forum @hbulgarini @bkchr @rphmeier @ggwpez @joepetrowski @acatangiu