Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Run all benchmarks "as tests" in short setup on every PR #2846

Merged
merged 31 commits into from
Jul 22, 2023
Merged

Run all benchmarks "as tests" in short setup on every PR #2846

merged 31 commits into from
Jul 22, 2023

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jul 10, 2023 •
edited
Loading

Inspired by: #2806 (comment)

Closes: #2806

TODOs

  • check # TODO: can we remove this?
  • update substrate ref because of asset-hub-westend issue

@bkontur bkontur added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 10, 2023
@bkontur bkontur marked this pull request as ready for review July 10, 2023 14:51
@bkontur bkontur requested review from a team as code owners July 10, 2023 14:51
@bkontur bkontur mentioned this pull request Jul 10, 2023
Closed
2 tasks
@bkontur bkontur added the A0-please_review Pull request needs code review. label Jul 10, 2023
ggwpez
ggwpez approved these changes Jul 10, 2023
View reviewed changes
.gitlab-ci.yml
# # benchmarks jobs
# # TODO: can we remove this?-
- scripts/ci/gitlab/pipeline/benchmarks.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one is automatically creating a MR to update the weights? I dont know if that is used.

Copy link
Contributor

@alvicsam alvicsam Jul 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but it works only with release-parachains-v* branches. Last time it was used month ago

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez yes, it is used for the releases, when the benchmark job is triggered from git lab. We used to do it manually so far

Copy link
Contributor Author

@bkontur bkontur Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorPopelyaev @ggwpez @joepetrowski @chevdor @alvicsam @bkchr
so for the very next release to regenerate weights, do we want to use:

  1. old way with manual gitlab job?
  2. new bot bench $ all ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkontur lets's proceed with the new bot solution if it does a thing, but I would still keep the old pipeline yaml, as a plan B. At least for the next release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorPopelyaev ok, good point

@paritytech-ci paritytech-ci requested a review from a team July 10, 2023 15:15
bkontur and others added 2 commits July 11, 2023 09:03
@bkontur @alvicsam
Update scripts/ci/gitlab/pipeline/short-benchmarks.yml
fc9ffa4 
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@bkontur
Updated TODO
0c2e008
@bkontur bkontur mentioned this pull request Jul 11, 2023
Merged
@bkontur
Copy link
Contributor Author

bkontur commented Jul 11, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur bkontur requested a review from alvicsam July 11, 2023 22:40
@paritytech-ci paritytech-ci requested a review from a team July 12, 2023 07:19
@bkontur
Copy link
Contributor Author

bkontur commented Jul 12, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur
[asset-conv] native asset change
9baf9f6
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
c40cba3
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
0c1aedb
@bkontur
Dedicated AssetBalance type for pallet_assets instances
e93fecc
@bkontur
Improved local vs foreign asset handling + test for not allowing pool…
f40746f 
…_assets in pool
@bkontur
Removed into_multiasset_id
2145285
@bkontur
Fix
70daf3b
@bkontur
Refactor
1f6c814
@bkontur
Fixed create_pool for benchmark with LocalAndForeignAssets (finally f…
fcece4c 
…ound it)
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
82ffbb2
@bkontur
Revert
d9636dc
@bkontur
fmt
6a19ff0
@bkontur
Migrates pools with MultiLocation { parents: 0, interior: Here } to…
1d82b31 
… `MultiLocation { parents: 1, interior: Here }`
@bkontur
Allow set_storage for AllowMultiAssetPools / `LiquidityWithdrawal…
fb101a3 
…Fee`
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
58db05f
@bkontur
Benchmarks work
84547be
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
8a4c351
@bkontur
Removed comment + more defensive migration
f05cd2e
@bkontur
T::Currency::transfer -> Balances::transfer_all in migration
c79882b
@bkontur
Change pool_id in migration
e3c3b83
@bkontur
Merge remote-tracking branch 'origin/master' into bko-short-benchmarks
a5af430
@bkontur
Copy link
Contributor Author

bkontur commented Jul 22, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit f022e03 into master Jul 22, 2023
40 checks passed
@paritytech-processbot paritytech-processbot bot deleted the bko-short-benchmarks branch July 22, 2023 06:30
@bkontur bkontur mentioned this pull request Jul 22, 2023
Merged
@bkontur bkontur mentioned this pull request Aug 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@ggwpez ggwpez ggwpez approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sergejparity sergejparity sergejparity approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI/CD] Run all benchmarks as (unit)tests on every PR
5 participants
@bkontur @EgorPopelyaev @ggwpez @alvicsam @sergejparity