Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

feat(ci): update runtime build workflow #471

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Jun 4, 2021

  • switch to a tag (v0.1.0) for the chevdor/srtool-actions (previously using a draft branch)
  • trigger to only tags & ignore folders not involved in the runtime
  • add weekly build schedule (every Monday @ 2am)
  • add timestamp to the artifacts

@chevdor
Copy link
Contributor Author

chevdor commented Jun 4, 2021

@chevdor chevdor requested a review from s3krit June 4, 2021 09:48
- switch to a tag for the chevdor/srtool-actions
- trigger to only tags & ignore folders not involved in the runtime
- add weekly build schedule
- add timestamp to the artifacts
Copy link
Contributor

@s3krit s3krit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just leaving a comment for now till my questions are addressed

on:
push:
tags:
- "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific pattern of tab we could match on rather than any tag?

Copy link
Contributor Author

@chevdor chevdor Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the existing tags (https://github.com/paritytech/cumulus/tags) and for now, the list is too short for a pattern. Since the frequency of new tags is still low, I think picking up all tags is better than every single push and fair for now. My proposal would be to refine the pattern as soon as we start using tags , that would trigger the runtime build but that we also want to exclude.

.github/workflows/srtool.yml Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jun 4, 2021

* add weekly build schedule (every Monday @ 2am)

What is the point of this?

@chevdor
Copy link
Contributor Author

chevdor commented Jun 4, 2021

  • add weekly build schedule (every Monday @ 2am)
    What is the point of this?

Since the frequency of tagging is low (at least currently), I want to ensure we don't end up not building the runtime for a too long period of time and then discover potential issues with the CI when we do need it wot run and work.

Why monday 2am: I think a weekly build is fair and not overdone. It runs when it will disturb no one and we will have potential issues visible mondays first hour. We totally can reconsider the frequency up or down if the activity of the repo changes one way or another.

I think it can also be convenient for people who want to test to have a fairly fresh runtime build.

@bkchr
Copy link
Member

bkchr commented Jun 4, 2021

  • add weekly build schedule (every Monday @ 2am)
    What is the point of this?

Since the frequency of tagging is low (at least currently), I want to ensure we don't end up not building the runtime for a too long period of time and then discover potential issues with the CI when we do need it wot run and work.

And how will you find out that it doesn't build anymore? Remember to check every monday if the build succeeded?

@chevdor
Copy link
Contributor Author

chevdor commented Jun 4, 2021

And how will you find out that it doesn't build anymore? Remember to check every monday if the build succeeded?

While that would be an option, it would be far from convenient...

I prefer github to simply let me know.
image

@bkchr
Copy link
Member

bkchr commented Jun 4, 2021

Okay, I didn't know that github actions support to send email automatically. That is fine.

@chevdor chevdor requested a review from s3krit June 4, 2021 23:32
@chevdor chevdor merged commit 9ff7252 into paritytech:master Jun 10, 2021
@chevdor chevdor deleted the wk-srtool-wf-update branch June 16, 2021 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants