Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Statemint Reserve Asset Transfer #552

Merged
merged 23 commits into from
Oct 5, 2021
Merged

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Jul 27, 2021

This PR adds a FungiblesAdapter as an asset transactor to Statemint to allow for Reserve-based asset transfers of Statemint assets.

Todos

  • Add the same config to Statemine and Westmint

@apopiak apopiak added the T7-system_parachains This PR/Issue is related to System Parachains. label Jul 27, 2021
@apopiak apopiak added this to In progress in Common Good Parachains via automation Jul 27, 2021
@apopiak apopiak requested a review from gavofyork August 12, 2021 14:11
@apopiak apopiak marked this pull request as ready for review August 12, 2021 14:12
@apopiak
Copy link
Contributor Author

apopiak commented Aug 12, 2021

Config looks ok based on the xcm simulator test with a similar mock runtime here:
https://github.com/paritytech/polkadot/pull/3548/files#diff-0c1e73932c0f34b91c9dd40c479baa1f7550f4541ea15e74129f7fd94440da97R248

@apopiak apopiak moved this from In progress to Review in progress in Common Good Parachains Aug 16, 2021
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 comments, but they all apply to the statemint and westmint XCM configs.

On another note, the syntax for the XCM config is arcane, I wonder if we can use some macro magic to solve it...?

polkadot-parachains/statemine/src/lib.rs Outdated Show resolved Hide resolved
polkadot-parachains/statemine/src/lib.rs Outdated Show resolved Hide resolved
polkadot-parachains/statemine/src/lib.rs Outdated Show resolved Hide resolved
@shawntabrizi shawntabrizi self-requested a review August 26, 2021 16:22
Copy link
Contributor

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks okay to me.

I assume we have tested this locally and all that?

Also an end to end test on westend when that is ready would be good

Common Good Parachains automation moved this from Review in progress to Reviewer approved Aug 31, 2021
@apopiak
Copy link
Contributor Author

apopiak commented Aug 31, 2021

this looks okay to me.

I assume we have tested this locally and all that?

Also an end to end test on westend when that is ready would be good

As mentioned it was tested via XCM sim. I've had issues getting it to test locally with Polkadot js apps due to types issues (with XCM) and was hoping an end-to-end test on Westend would be enough.
We also need to set up some integration tests in general.

@apopiak
Copy link
Contributor Author

apopiak commented Oct 5, 2021

Tested this sufficiently to merge and then experiment more with a deployment on Westend.

@apopiak apopiak merged commit caa8b81 into master Oct 5, 2021
@apopiak apopiak deleted the apopiak/reserve-asset-transfer branch October 5, 2021 09:35
Common Good Parachains automation moved this from Reviewer approved to Done Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T7-system_parachains This PR/Issue is related to System Parachains.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants