Fix package naming conflict #753
Conversation
|
Looks fine to me, but are there really no other places where this is referenced? (That need to be updated) |
I didn't find any (more) https://github.com/paritytech/cumulus/search?q=rococo-runtime |
|
You mean references in other repositories? |
|
This should be merged to |
| @@ -19,7 +19,7 @@ hex-literal = "0.2.1" | |||
| async-trait = "0.1.42" | |||
|
|
|||
| # Parachain runtimes | |||
| rococo-parachain-runtime = { package = "rococo-runtime", path = "rococo" } | |||
| rococo-parachain-runtime = { package = "rococo-parachain-runtime", path = "rococo" } | |||
There was a problem hiding this comment.
the rename is now obsolete
(package = "rococo-parachain-runtime", ) part
There was a problem hiding this comment.
What do you mean? I don't understand, sorry
There was a problem hiding this comment.
I means you can remove package = .. part now
Yes, it will be merged to |
* package naming conflict fixed (#753) * Fix rococo naming Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com>
Fixes: #750
The problem was there are two different packages with the same name:
rococo-runtimeand it was generating some conflict when compiling since they have different versions too.Not sure why it is only complaining when using
--features runtime-benchmarks