Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update XCM MultiLocation prefixes for assets #831

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Update XCM MultiLocation prefixes for assets #831

merged 1 commit into from
Dec 13, 2021

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Dec 4, 2021

Ensure that any assets under the Assets pallet is prefixed by a PalletInstance(assets_pallet_index) junction.

This was referenced Dec 13, 2021
Closed
Closed
shawntabrizi
shawntabrizi approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to allow multiple different kinds of assets pallets on the parachain?

@KiChjang
Copy link
Contributor Author

Yes, currently GeneralIndex is only used to describe fungibles via the assets pallet; in the future, we may want to include the uniques pallet as well, or maybe some other pallet describing other kinds of assets, and it's best that we future-proof it now.

@KiChjang
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e27fd22 into master Dec 13, 2021
@paritytech-processbot paritytech-processbot bot deleted the kckyeung/update-xcm-prefix branch December 13, 2021 23:52
@joepetrowski joepetrowski added this to the statemint-v7.0.0 milestone Jan 7, 2022
@girazoki girazoki mentioned this pull request Jan 10, 2022
Merged
@joepetrowski joepetrowski mentioned this pull request Aug 24, 2023
Open
@apopiak apopiak mentioned this pull request Jan 25, 2022
Closed
@zqhxuyuan zqhxuyuan mentioned this pull request Jan 28, 2022
Merged
12 tasks
@librelois librelois mentioned this pull request Feb 7, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@apopiak apopiak Awaiting requested review from apopiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
statemint-v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KiChjang @gavofyork @shawntabrizi @joepetrowski