Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added summary to action and fixed exit error #17

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Added summary to action and fixed exit error #17

merged 11 commits into from
Mar 18, 2024

Conversation

Bullrich
Copy link
Collaborator

  • Added a nice summary that is shown after every run.
  • Made exiting of application conditional on the state.
    • With the finally it would always exit as successful even if it failed.
    • Now it sets an error code when valid.
  • Implemented action on itself.
    • Now it will run after each push.

@Bullrich Bullrich added the bug Something isn't working label Mar 15, 2024
@Bullrich Bullrich self-assigned this Mar 15, 2024
@Bullrich Bullrich requested a review from a team as a code owner March 15, 2024 15:36
@Bullrich
Copy link
Collaborator Author

Find an example summary here:

Example

@Bullrich Bullrich mentioned this pull request Mar 15, 2024
@Bullrich Bullrich merged commit d1ee5d0 into main Mar 18, 2024
8 checks passed
@Bullrich Bullrich deleted the table branch March 18, 2024 10:10
Bullrich added a commit that referenced this pull request Mar 18, 2024
Updated to version `1.1.0`.

We can release this new version with the new library.

This needs to be merged after:
- #15 
- #16 
- #17
- #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants