Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced trivy for dependabot #32

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Replaced trivy for dependabot #32

merged 2 commits into from
Jan 6, 2023

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jan 6, 2023

It seems trivy is not the best option to analyze our repository as it doesn't differ production dependencies from dev dependencies for yarn projects.

As recommended by @mutantcornholio in #30 I had replaced this check in favor of Dependabot as it can differ production dependencies from dev dependencies.

This PR closes #31.

@Bullrich Bullrich added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 6, 2023
@Bullrich Bullrich requested a review from a team as a code owner January 6, 2023 12:38
@Bullrich Bullrich self-assigned this Jan 6, 2023
@Bullrich Bullrich requested a review from a team as a code owner January 6, 2023 12:38
Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Bullrich Bullrich merged commit 9004ecd into master Jan 6, 2023
@Bullrich Bullrich deleted the jb/trivy-to-dependabot branch January 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace trivy for dependabot
2 participants