Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Add BEEFY gadget as extra peer set #80

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Add BEEFY gadget as extra peer set #80

merged 2 commits into from
Feb 8, 2021

Conversation

adoerr
Copy link
Contributor

@adoerr adoerr commented Feb 8, 2021

No description provided.

@adoerr adoerr requested a review from tomusdrw February 8, 2021 17:13
@adoerr adoerr marked this pull request as draft February 8, 2021 17:21
@adoerr adoerr removed the request for review from tomusdrw February 8, 2021 17:22
@adoerr adoerr requested a review from tomusdrw February 8, 2021 17:44
@adoerr adoerr marked this pull request as ready for review February 8, 2021 17:48
tomusdrw
tomusdrw approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

it would be really good to somehow have a end-to-end test for this, basically running two nodes and making sure they produce justifications (subscription). I'll open a separate issue for that.

@tomusdrw tomusdrw merged commit 9f4a049 into paritytech:master Feb 8, 2021
@tomusdrw tomusdrw mentioned this pull request Feb 8, 2021
Closed
@adoerr adoerr deleted the ad-peers-set branch February 9, 2021 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adoerr @tomusdrw