Call middleware #318
Merged
Call middleware #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Oct 5, 2018
|
@dvdplm Indeed. The middleware that allows you to handle every single |
ordian
reviewed
Oct 30, 2018
| if cfg!(windows) { 58 } else { 59 }, | ||
| result.len() | ||
| assert!( | ||
| result.len() == 58 || result.len() == 59 |
There was a problem hiding this comment.
looks like this modification (58 for Windows) was only required for appveyor and not travis windows, I guess travis is using visualstudio2017 toolchain
There was a problem hiding this comment.
Right, although afaict the port is just chosen randomly, so it's weird to assume that it's always going to be a 5-digit number.
tomusdrw
added a commit
that referenced
this pull request
Oct 30, 2018
* Avoid Boxing in middleware. * Add on_call to the middleware. * Properly workaround FnOnce in the on_drop interface. * Re-export separator from tcp server. * Fix windows build again.
tomusdrw
added a commit
that referenced
this pull request
Oct 30, 2018
* Avoid Boxing in middleware. * Add on_call to the middleware. * Properly workaround FnOnce in the on_drop interface. * Re-export separator from tcp server. * Fix windows build again.
CriesofCarrots
pushed a commit
to CriesofCarrots/jsonrpc
that referenced
this pull request
Dec 7, 2018
* Avoid Boxing in middleware. * Add on_call to the middleware. * Properly workaround FnOnce in the on_drop interface. * Re-export separator from tcp server. * Fix windows build again.
CriesofCarrots
pushed a commit
to solana-labs/jsonrpc
that referenced
this pull request
Dec 7, 2018
* Avoid Boxing in middleware. * Add on_call to the middleware. * Properly workaround FnOnce in the on_drop interface. * Re-export separator from tcp server. * Fix windows build again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.