Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow one-way bounds on trait generic parameters. #336

Merged
merged 2 commits into from Nov 13, 2018
Merged

Allow one-way bounds on trait generic parameters. #336

merged 2 commits into from Nov 13, 2018

Conversation

tomusdrw
Copy link
Contributor

Implemented to maintain backward compatibility.
In the future we should just rewrite the macro #66

Related paritytech/substrate#1098

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one point that could be improved, but also is not that important.

macros/src/auto_args.rs Outdated Show resolved Hide resolved
macros/src/auto_args.rs Show resolved Hide resolved
@tomusdrw tomusdrw removed the request for review from rphmeier November 13, 2018 10:29
@bkchr bkchr merged commit 62d739e into master Nov 13, 2018
@bkchr bkchr deleted the td-bounds branch November 13, 2018 12:19
CriesofCarrots pushed a commit to CriesofCarrots/jsonrpc that referenced this pull request Dec 7, 2018
* Allow one-way bounds on trait generic parameters.

* Remove unused macro.
CriesofCarrots pushed a commit to solana-labs/jsonrpc that referenced this pull request Dec 7, 2018
* Allow one-way bounds on trait generic parameters.

* Remove unused macro.
faern pushed a commit to mullvad/jsonrpc that referenced this pull request Jan 18, 2019
* Allow one-way bounds on trait generic parameters.

* Remove unused macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants