Update serde dependency to 0.9.0 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets json-rpc build on stable (1.15) without needing serde_codegen
|
Thank you! Closes #16 |
rphmeier
reviewed
Feb 4, 2017
core/src/lib.rs
Outdated
|
|
||
| #[macro_use] extern crate log; | ||
| extern crate serde; | ||
| extern crate serde_json; | ||
| #[macro_use] extern crate serde_derive; |
There was a problem hiding this comment.
style: would prefer to keep #[macro_use] links adjacent
|
tiny style nit but LGTM. Out of curiosity, how does this affect compile times? |
Running |
rphmeier
approved these changes
Feb 4, 2017
|
All good then, thanks! |
debris
approved these changes
Feb 5, 2017
|
side note, we'll need quite substantial refactoring to switch |
|
When do you think you can release a version with this PR? Using a git dependency right now since I can't use serde 0.8.0 due to another dependency. It works for development but I can't do an actual release to crates.io with it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets jsonrpc build on stable (1.15) without needing serde_codegen