Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to serde 0.9 #39

Closed
vitiral opened this issue Feb 9, 2017 · 3 comments
Closed

migrate to serde 0.9 #39

vitiral opened this issue Feb 9, 2017 · 3 comments

Comments

@vitiral
Copy link

vitiral commented Feb 9, 2017

rust 0.15 was just released and with it custom derive!

Serde released version 0.9, which is now incompatible with this library:

error[E0308]: mismatched types
  --> src/api/handler.rs:40:12
   |
40 |         Ok(value)
   |            ^^^^^ expected enum `jsonrpc_core::Value`, found enum `serde_json::Value`
   |
   = note: expected type `jsonrpc_core::Value`
   = note:    found type `serde_json::Value`

migrating shouldn't be difficult. If you would like, I can open a pull request.

@tomusdrw
Copy link
Contributor

It's already fixed in #38, we're just awaiting to release a new version which should happen soon.

@tomusdrw
Copy link
Contributor

jsonrpc-core = 6.0 with serde-0.9 was just recently released, make sure to try it out :)

@vitiral
Copy link
Author

vitiral commented Feb 16, 2017

awesome thanks! Great library btw -- I use it with nickel (currently) and it integrates seamlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants