Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nit in ServerBuilder::custom_tokio_runtime #512

Merged
merged 1 commit into from Oct 12, 2021
Merged

fix: nit in ServerBuilder::custom_tokio_runtime #512

merged 1 commit into from Oct 12, 2021

Conversation

niklasad1
Copy link
Member

The builders must return Self when taking ownership which is a super nit

TarikGul
TarikGul approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niklasad1 niklasad1 merged commit 07df2f8 into master Oct 12, 2021
@niklasad1 niklasad1 deleted the na-nit-server-builder-custom-tokio branch October 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@TarikGul TarikGul TarikGul approved these changes

@maciejhirsz maciejhirsz Awaiting requested review from maciejhirsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niklasad1 @dvdplm @TarikGul