[rpc module]: improve TestSubscription to return None when closed
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Nov 16, 2021
| assert_eq!(id, v2::params::SubscriptionId::Num(my_sub.subscription_id())); | ||
|
|
||
| // close the subscription to ensure it doesn't return any items. | ||
| my_sub.close(); |
There was a problem hiding this comment.
technically this doesn't test that inner thread was terminated correctly and it's bit cheating because we terminate the SubscriptionSink directly there but we do the exact thing in WsServer so should be sufficient here.
There was a problem hiding this comment.
I guess it's possible to inject a channel/flag to the RpcModule for testing but really annoying for other however the SubscriptionSink terminates the subscription once SubscriptionSink::send fails anyway...
dvdplm
approved these changes
Nov 16, 2021
maciejhirsz
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.