Remove deny_unknown_fields from Request and Response
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Jun 22, 2022
tgmichel
changed the title
deny_unknown_fields from Requestdeny_unknown_fields from Request and Response
lexnv
approved these changes
Jun 22, 2022
jsdw
reviewed
Jun 22, 2022
| @@ -545,7 +545,7 @@ async fn invalid_request_should_not_close_connection() { | |||
| let addr = server().await; | |||
| let mut client = WebSocketTestClient::new(addr).with_default_timeout().await.unwrap().unwrap(); | |||
|
|
|||
| let req = r#"{"jsonrpc":"2.0","method":"bar","id":1,"is_not_request_object":1}"#; | |||
There was a problem hiding this comment.
Could we add a quick test just to prove that something like {"jsonrpc":"2.0","method":"bar","id":1,"is_not_request_object":1} is now valid and catch any regresstions?
jsdw
approved these changes
Jun 22, 2022
librelois
added a commit
to PureStake/jsonrpsee
that referenced
this pull request
Aug 16, 2022
…h#803) * Remove `deny_unknown_fields` * Update invalid request tests * Remove `is_not_request_object` field from req in test * Remove `deny_unknown_fields` from `Response` * Add test to verify unknown field results in valid request
librelois
added a commit
to PureStake/jsonrpsee
that referenced
this pull request
Aug 16, 2022
…h#803) * Remove `deny_unknown_fields` * Update invalid request tests * Remove `is_not_request_object` field from req in test * Remove `deny_unknown_fields` from `Response` * Add test to verify unknown field results in valid request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #797
@niklasad1 please let me know if this is prefered over keeping optional
deny_unknown_fieldsbehind a feature.