-
Notifications
You must be signed in to change notification settings - Fork 130
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
move transaction extensions to a separate folder
- Loading branch information
Showing
5 changed files
with
249 additions
and
201 deletions.
There are no files selected for viewing
218 changes: 218 additions & 0 deletions
218
bin/runtime-common/src/extensions/check_obsolete_extension.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,218 @@ | ||
// Copyright (C) Parity Technologies (UK) Ltd. | ||
// This file is part of Parity Bridges Common. | ||
|
||
// Parity Bridges Common is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity Bridges Common is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity Bridges Common. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
//! Transaction extension that rejects bridge-related transactions, that include | ||
//! obsolete (duplicated) data or do not pass some additional pallet-specific | ||
//! checks. | ||
|
||
use crate::messages_call_ext::MessagesCallSubType; | ||
use pallet_bridge_grandpa::CallSubType as GrandpaCallSubType; | ||
use pallet_bridge_parachains::CallSubType as ParachainsCallSubtype; | ||
use sp_runtime::transaction_validity::TransactionValidity; | ||
|
||
/// A duplication of the `FilterCall` trait. | ||
/// | ||
/// We need this trait in order to be able to implement it for the messages pallet, | ||
/// since the implementation is done outside of the pallet crate. | ||
pub trait BridgeRuntimeFilterCall<Call> { | ||
/// Checks if a runtime call is valid. | ||
fn validate(call: &Call) -> TransactionValidity; | ||
} | ||
|
||
impl<T, I: 'static> BridgeRuntimeFilterCall<T::RuntimeCall> for pallet_bridge_grandpa::Pallet<T, I> | ||
where | ||
T: pallet_bridge_grandpa::Config<I>, | ||
T::RuntimeCall: GrandpaCallSubType<T, I>, | ||
{ | ||
fn validate(call: &T::RuntimeCall) -> TransactionValidity { | ||
GrandpaCallSubType::<T, I>::check_obsolete_submit_finality_proof(call) | ||
} | ||
} | ||
|
||
impl<T, I: 'static> BridgeRuntimeFilterCall<T::RuntimeCall> | ||
for pallet_bridge_parachains::Pallet<T, I> | ||
where | ||
T: pallet_bridge_parachains::Config<I>, | ||
T::RuntimeCall: ParachainsCallSubtype<T, I>, | ||
{ | ||
fn validate(call: &T::RuntimeCall) -> TransactionValidity { | ||
ParachainsCallSubtype::<T, I>::check_obsolete_submit_parachain_heads(call) | ||
} | ||
} | ||
|
||
impl<T: pallet_bridge_messages::Config<I>, I: 'static> BridgeRuntimeFilterCall<T::RuntimeCall> | ||
for pallet_bridge_messages::Pallet<T, I> | ||
where | ||
T::RuntimeCall: MessagesCallSubType<T, I>, | ||
{ | ||
/// Validate messages in order to avoid "mining" messages delivery and delivery confirmation | ||
/// transactions, that are delivering outdated messages/confirmations. Without this validation, | ||
/// even honest relayers may lose their funds if there are multiple relays running and | ||
/// submitting the same messages/confirmations. | ||
fn validate(call: &T::RuntimeCall) -> TransactionValidity { | ||
call.check_obsolete_call() | ||
} | ||
} | ||
|
||
/// Declares a runtime-specific `BridgeRejectObsoleteHeadersAndMessages` signed extension. | ||
/// | ||
/// ## Example | ||
/// | ||
/// ```nocompile | ||
/// generate_bridge_reject_obsolete_headers_and_messages!{ | ||
/// Call, AccountId | ||
/// BridgeRococoGrandpa, BridgeRococoMessages, | ||
/// BridgeRococoParachains | ||
/// } | ||
/// ``` | ||
/// | ||
/// The goal of this extension is to avoid "mining" transactions that provide outdated bridged | ||
/// headers and messages. Without that extension, even honest relayers may lose their funds if | ||
/// there are multiple relays running and submitting the same information. | ||
#[macro_export] | ||
macro_rules! generate_bridge_reject_obsolete_headers_and_messages { | ||
($call:ty, $account_id:ty, $($filter_call:ty),*) => { | ||
#[derive(Clone, codec::Decode, Default, codec::Encode, Eq, PartialEq, sp_runtime::RuntimeDebug, scale_info::TypeInfo)] | ||
pub struct BridgeRejectObsoleteHeadersAndMessages; | ||
impl sp_runtime::traits::TransactionExtensionBase for BridgeRejectObsoleteHeadersAndMessages { | ||
const IDENTIFIER: &'static str = "BridgeRejectObsoleteHeadersAndMessages"; | ||
type Implicit = (); | ||
} | ||
impl<Context> sp_runtime::traits::TransactionExtension<$call, Context> for BridgeRejectObsoleteHeadersAndMessages { | ||
type Pre = (); | ||
type Val = (); | ||
|
||
fn validate( | ||
&self, | ||
origin: <$call as sp_runtime::traits::Dispatchable>::RuntimeOrigin, | ||
call: &$call, | ||
_info: &sp_runtime::traits::DispatchInfoOf<$call>, | ||
_len: usize, | ||
_context: &mut Context, | ||
_self_implicit: Self::Implicit, | ||
_inherited_implication: &impl codec::Encode, | ||
) -> Result< | ||
( | ||
sp_runtime::transaction_validity::ValidTransaction, | ||
Self::Val, | ||
<$call as sp_runtime::traits::Dispatchable>::RuntimeOrigin, | ||
), sp_runtime::transaction_validity::TransactionValidityError | ||
> { | ||
let tx_validity = sp_runtime::transaction_validity::ValidTransaction::default(); | ||
$( | ||
let call_filter_validity = < | ||
$filter_call as | ||
$crate::extensions::check_obsolete_extension::BridgeRuntimeFilterCall<$call> | ||
>::validate(call)?; | ||
let tx_validity = tx_validity.combine_with(call_filter_validity); | ||
)* | ||
Ok((tx_validity, (), origin)) | ||
} | ||
|
||
fn prepare( | ||
self, | ||
_val: Self::Val, | ||
_origin: &<$call as sp_runtime::traits::Dispatchable>::RuntimeOrigin, | ||
_call: &$call, | ||
_info: &sp_runtime::traits::DispatchInfoOf<$call>, | ||
_len: usize, | ||
_context: &Context, | ||
) -> Result<Self::Pre, sp_runtime::transaction_validity::TransactionValidityError> { | ||
Ok(()) | ||
} | ||
} | ||
}; | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use crate::extensions::check_obsolete_extension::BridgeRuntimeFilterCall; | ||
use codec::Encode; | ||
use frame_support::assert_err; | ||
use sp_runtime::{ | ||
traits::DispatchTransaction, | ||
transaction_validity::{InvalidTransaction, TransactionValidity, ValidTransaction}, | ||
}; | ||
|
||
#[derive(Encode)] | ||
pub struct MockCall { | ||
data: u32, | ||
} | ||
|
||
impl sp_runtime::traits::Dispatchable for MockCall { | ||
type RuntimeOrigin = (); | ||
type Config = (); | ||
type Info = (); | ||
type PostInfo = (); | ||
|
||
fn dispatch( | ||
self, | ||
_origin: Self::RuntimeOrigin, | ||
) -> sp_runtime::DispatchResultWithInfo<Self::PostInfo> { | ||
unimplemented!() | ||
} | ||
} | ||
|
||
struct FirstFilterCall; | ||
impl BridgeRuntimeFilterCall<MockCall> for FirstFilterCall { | ||
fn validate(call: &MockCall) -> TransactionValidity { | ||
if call.data <= 1 { | ||
return InvalidTransaction::Custom(1).into() | ||
} | ||
|
||
Ok(ValidTransaction { priority: 1, ..Default::default() }) | ||
} | ||
} | ||
|
||
struct SecondFilterCall; | ||
impl BridgeRuntimeFilterCall<MockCall> for SecondFilterCall { | ||
fn validate(call: &MockCall) -> TransactionValidity { | ||
if call.data <= 2 { | ||
return InvalidTransaction::Custom(2).into() | ||
} | ||
|
||
Ok(ValidTransaction { priority: 2, ..Default::default() }) | ||
} | ||
} | ||
|
||
#[test] | ||
fn test() { | ||
generate_bridge_reject_obsolete_headers_and_messages!( | ||
MockCall, | ||
(), | ||
FirstFilterCall, | ||
SecondFilterCall | ||
); | ||
|
||
assert_err!( | ||
BridgeRejectObsoleteHeadersAndMessages.validate_only((), &MockCall { data: 1 }, &(), 0), | ||
InvalidTransaction::Custom(1) | ||
); | ||
|
||
assert_err!( | ||
BridgeRejectObsoleteHeadersAndMessages.validate_only((), &MockCall { data: 2 }, &(), 0), | ||
InvalidTransaction::Custom(2) | ||
); | ||
|
||
assert_eq!( | ||
BridgeRejectObsoleteHeadersAndMessages | ||
.validate_only((), &MockCall { data: 3 }, &(), 0) | ||
.unwrap() | ||
.0, | ||
ValidTransaction { priority: 3, ..Default::default() } | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright (C) Parity Technologies (UK) Ltd. | ||
// This file is part of Parity Bridges Common. | ||
|
||
// Parity Bridges Common is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity Bridges Common is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity Bridges Common. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
//! Bridge-specific transaction extensions. | ||
|
||
pub mod check_obsolete_extension; | ||
pub mod priority_calculator; | ||
pub mod refund_relayer_extension; |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.