Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trie-standardmap] remove from parity-common #147

Merged
merged 3 commits into from May 12, 2019
Merged

[trie-standardmap] remove from parity-common #147

merged 3 commits into from May 12, 2019

Conversation

ordian
Copy link
Member

@ordian ordian commented May 11, 2019

As @dvdplm suggested.
Seems to live in https://github.com/paritytech/trie/tree/master/test-support/trie-standardmap now and not used by other projects.

@ordian ordian requested a review from dvdplm May 11, 2019 16:10
@dvdplm dvdplm requested a review from bkchr May 11, 2019 16:13
dvdplm
dvdplm approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkchr this is not used in substrate anywhere right?

dvdplm
dvdplm suggested changes May 11, 2019
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordian just noticed that it's a dev dependency of ethcore

dvdplm
dvdplm approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we check that ethcore/snapshot can use the migrated crate from trie this lgtm.

@sorpaas sorpaas merged commit e208250 into master May 12, 2019
@sorpaas sorpaas deleted the ao-remove-trie-standardmap branch May 12, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@sorpaas sorpaas sorpaas approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ordian @dvdplm @sorpaas