Make triehash generic over hasher #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
requested review from
rphmeier and
debris
and removed request for
rphmeier
rphmeier
approved these changes
Jul 6, 2018
Bump patricia_trie to v0.2.1
* master: Bump triehash to v0.1.1 Prepare triehash for cargo publication
Add keccak-hasher test-helper as a test dep
twittner
approved these changes
Jul 9, 2018
triehash/src/lib.rs
Outdated
| { | ||
| let gen_input: Vec<_> = input | ||
| // first put elements into btree to sort them and to remove duplicates | ||
| .into_iter() | ||
| .map(|(k, v)| (keccak(k), v)) | ||
| .map(|(k, v)| (H::hash(&k.as_ref()), v)) |
There was a problem hiding this comment.
Just k.as_ref() should be enough.
triehash/src/lib.rs
Outdated
| .collect::<BTreeMap<_, _>>() | ||
| // then move them to a vector | ||
| .into_iter() | ||
| .map(|(k, v)| (as_nibbles(&k), v) ) | ||
| .map(|(k, v)| (as_nibbles(&k.as_ref()), v) ) |
There was a problem hiding this comment.
Just k.as_ref() should be enough.
ordian
added a commit
that referenced
this pull request
Jan 14, 2020
dvdplm
added a commit
that referenced
this pull request
Mar 26, 2020
* kvdb-rocksdb: no overlay experiment * kvdb-rocksdb: remove unused dep * kvdb-rocksdb: panic on write failure * kvdb: remove write_buffered and flush * kvdb: update changelog * kvdb-rocksdb: update changelog * kvdb-web: update changelog * kvdb-memory: update changelog * kvdb-rocksdb: fix the bench * kvdb-rocksdb: fix the bench #2 * kvdb: cargo fmt * Apply suggestions from code review Co-Authored-By: David <dvdplm@gmail.com> * kvdb-rocksdb: s/acquired_val/value * kvdb-rocksdb: update the changelog Co-authored-by: David <dvdplm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
triehashfor use in Polkadot.