Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for release #361

Merged
merged 7 commits into from
Mar 16, 2020
Merged

Prep for release #361

merged 7 commits into from
Mar 16, 2020

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Mar 16, 2020

No description provided.

parity-util-mem/CHANGELOG.md Show resolved Hide resolved
fixed-hash/Cargo.toml Outdated Show resolved Hide resolved
@@ -1,17 +1,17 @@
[package]
name = "ethereum-types"
version = "0.8.0"
version = "0.8.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordian are you saying this must be 0.9 too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because it exposes fixed_hash::H256 from 0.6 instead of fixed_hash::H256 from 0.5

rlp/CHANGELOG.md Outdated Show resolved Hide resolved
parity-util-mem/CHANGELOG.md Outdated Show resolved Hide resolved
keccak-hash/CHANGELOG.md Outdated Show resolved Hide resolved
ethereum-types/CHANGELOG.md Outdated Show resolved Hide resolved
@@ -1,6 +1,6 @@
[package]
name = "keccak-hash"
version = "0.4.1"
version = "0.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this (until we resolve #146)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will obey, but are you sure that features available in keccak-hash used the libc feature from primitive-types in the past?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not about features anymore, once you expose a type in a lib

pub fn keccak<T: AsRef<[u8]>>(s: T) -> H256 {

and upgrade a dependency with that type in a semver breaking way, the breakage speads like a virus into the lib

dvdplm and others added 5 commits March 16, 2020 17:24
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
@dvdplm dvdplm marked this pull request as ready for review March 16, 2020 16:44
@dvdplm dvdplm self-assigned this Mar 16, 2020
@ordian ordian merged commit 32f8d96 into master Mar 16, 2020
@ordian ordian deleted the dp/chore/release-unreleased branch March 16, 2020 18:56
ordian added a commit that referenced this pull request Mar 23, 2020
* master:
  Memtest example for Rocksdb (#349)
  Prep for release (#361)
ordian added a commit that referenced this pull request Mar 26, 2020
* master:
  kvdb: no overlay (#313)
  Ban duplicates of parity-uil-mem from being linked into the same program (#363)
  Use correct license ID (#362)
  Memtest example for Rocksdb (#349)
  Prep for release (#361)
ordian added a commit that referenced this pull request Apr 22, 2020
* master:
  kvdb-rocksdb: optimize and rename iter_from_prefix  (#365)
  bump parity-util-mem (#376)
  parity-util-mem: fix for windows (#375)
  keccak-hash: fix bench and add one for range (#372)
  [parity-crypto] Release 0.6.1 (#373)
  keccak-hash: bump version to 0.5.1 (#371)
  keccak-hash: add keccak256_range and keccak512_range functions (#370)
  Allow pubkey recovery for all-zero messages (#369)
  Delete by prefix operator in kvdb (#360)
  kvdb: no overlay (#313)
  Ban duplicates of parity-uil-mem from being linked into the same program (#363)
  Use correct license ID (#362)
  Memtest example for Rocksdb (#349)
  Prep for release (#361)
  parity-util-mem: prepare release for 0.5.2 (#359)
  travis: test parity-util-mem on android (#358)
  parity-util-mem: update mimalloc feature (#352)
  kvdb: remove parity-bytes dependency (#351)
  parity-util-mem: use malloc for usable_size on android (#355)
  CI: troubleshoot macOS build (#356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants