Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primitive-types: add no_std support for serde feature #385

Merged
merged 3 commits into from
May 4, 2020
Merged

primitive-types: add no_std support for serde feature #385

merged 3 commits into from
May 4, 2020

Conversation

xu-cheng
Copy link
Contributor

@xu-cheng xu-cheng commented May 1, 2020

This adds no_std support to primitive-types with serde.

Due to rust-lang/cargo#3494,
a separate new feature serde_no_std is created.

@parity-cla-bot
Copy link

It looks like @xu-cheng hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@xu-cheng
Copy link
Contributor Author

xu-cheng commented May 1, 2020

[clabot:check]

@parity-cla-bot
Copy link

It looks like @xu-cheng signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@xu-cheng
primitive-types: add no_std support for serde feature
e143458 
This adds no_std support to primitive-types with serde.

Due to rust-lang/cargo#3494,
a separate new feature `serde_no_std` is created.
@xu-cheng xu-cheng changed the title primitive-types: add no_std support for serde features primitive-types: add no_std support for serde feature May 1, 2020
ordian
ordian approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This workaround is unfortunate, but I see no better way given how cargo currently treats features.
Could you add a test for this feature in .travis.yml and update the changelogs?

@xu-cheng
Copy link
Contributor Author

xu-cheng commented May 3, 2020

The CI is a success https://travis-ci.org/github/paritytech/parity-common/builds/682134094. But for some reason, it wasn't shown in the Github UI.

dvdplm
dvdplm approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dvdplm dvdplm merged commit 371f17f into paritytech:master May 4, 2020
@xu-cheng xu-cheng deleted the primitive-types-serde-no-std branch May 4, 2020 05:58
@xu-cheng
Copy link
Contributor Author

xu-cheng commented May 5, 2020

Thanks for the merging. Any chance to create a new release at crates.io?

@ordian ordian mentioned this pull request May 5, 2020
Merged
ordian added a commit that referenced this pull request May 5, 2020
@ordian
Merge branch 'master' into ao-type-metadata
dc92ac3 
* master: (56 commits)
  primitive-types: add no_std support for serde feature (#385)
  Add Rocksdb Secondary Instance Api (#384)
  kvdb-rocksdb: update rocksdb to 0.14 (#379)
  prepare releases for a few crates (#382)
  uint: fix UB in uint::from_big_endian (#381)
  Fix limit prefix delete case (#368)
  Add arbitrary trait implementation (#378)
  kvdb-rocksdb: optimize and rename iter_from_prefix  (#365)
  bump parity-util-mem (#376)
  parity-util-mem: fix for windows (#375)
  keccak-hash: fix bench and add one for range (#372)
  [parity-crypto] Release 0.6.1 (#373)
  keccak-hash: bump version to 0.5.1 (#371)
  keccak-hash: add keccak256_range and keccak512_range functions (#370)
  Allow pubkey recovery for all-zero messages (#369)
  Delete by prefix operator in kvdb (#360)
  kvdb: no overlay (#313)
  Ban duplicates of parity-uil-mem from being linked into the same program (#363)
  Use correct license ID (#362)
  Memtest example for Rocksdb (#349)
  ...
@mrcnski mrcnski mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xu-cheng @parity-cla-bot @dvdplm @ordian