Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rocksdb to 0.18 #629

Merged
merged 4 commits into from
Feb 18, 2022
Merged

update rocksdb to 0.18 #629

merged 4 commits into from
Feb 18, 2022

Conversation

ordian
Copy link
Member

@ordian ordian commented Feb 9, 2022

Supercedes #628.

niklasad1
niklasad1 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-rocksdb/rust-rocksdb#554 looks worthy of updating IMHO 👍

@ordian ordian merged commit 70a745a into master Feb 18, 2022
@ordian ordian deleted the ao-rocksdb branch February 18, 2022 16:34
@ordian
Copy link
Member Author

ordian commented Feb 18, 2022

Published.

@ordian ordian mentioned this pull request Feb 21, 2022
Merged
@nazar-pc
Copy link
Contributor

It is not working on Windows/MSVC apparently, which after Substrate upgrade breaks our CI 😞

https://github.com/subspace/subspace/runs/5612067150?check_suite_focus=true

This seems like a serious breaking change to me 😕

@nazar-pc nazar-pc mentioned this pull request Mar 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ordian @nazar-pc @niklasad1