Disable jemalloc on OpenBSD and MSVC where it is not working #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Mar 20, 2022
There was a problem hiding this comment.
Sorry about breaking your CI and thanks for the fix!
It wasn't caught because we're not testing kvdb-rocksdb on windows:
parity-common/.github/workflows/ci.yml
Line 146 in 70a745a
FYI: the long-term plan is to deprecate rocksdb backend in favor of https://github.com/paritytech/parity-db.
I know and can't wait for it 🙂 |
ordian
reviewed
Mar 20, 2022
|
Published to crates.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue introduced by #629 on MSVC target: https://github.com/subspace/subspace/runs/5612067150?check_suite_focus=true