Hackfix for funty breaking change #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
approved these changes
Feb 15, 2021
|
Not sure if we can wait until |
Yeah, I prepared this mostly to be ready if the fix is delayed. It would be better not having to merge&release it. |
thiolliere
approved these changes
Feb 15, 2021
|
This is an upstream bug that should be solved by downstream projects by pinning the crate. I don't see any reason to workaround this here in our code base. |
|
People can just solve this by pinning the crate on their own in the |
|
|
|
bitvec 0.20.2 has been released. It fixes the issue by depending on |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #249
The latest
funtyrelease seems to be backwards incompatible and asbitvecimportsfuncty = "1"projects can start to break without notice. This PR doesn't address the issue but can work as a temporary solution.