Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Propagations & local transactions tracking #3491

Merged
merged 15 commits into from
Nov 20, 2016
Merged

Propagations & local transactions tracking #3491

merged 15 commits into from
Nov 20, 2016

Conversation

tomusdrw
Copy link
Collaborator

  1. Keeps track of pending transactions propagations
  2. Maintains an additional list of local transactions
  3. Simple GUI to display transaction queue content and local transactions with possibility of re-submission.
  4. Identifies local transactions coming from network correctly (by checking accounts list)

Closes #2929
Closes #2627

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M7-ui A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 17, 2016
@tomusdrw
Copy link
Collaborator Author

Would love some help with the UI (I don't really know how to re-use stuff from other dapps (or how much I can/should re-use in general))
I tried to keep it non-styled for now so that it will be easy to make it properly:
screenshot from 2016-11-17 13 43 41

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3bfd6c5 on transactions-propagate into * on master*.

@gavofyork
Copy link
Contributor

looks awesome

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 18, 2016
@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Nov 18, 2016 •
edited

Spoke with @jacogr and the app (in some form) will be integrated into main UI later.

@tomusdrw tomusdrw mentioned this pull request Nov 18, 2016
Closed
@jacogr jacogr mentioned this pull request Nov 18, 2016
Closed
@jacogr
Copy link
Contributor

jacogr commented Nov 18, 2016

One word: YES.

@gavofyork gavofyork added A9-FUCKYEAH!1 💯 Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;) and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 18, 2016
@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. and removed A9-FUCKYEAH!1 💯 Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;) labels Nov 18, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Nov 20, 2016
@gavofyork
Copy link
Contributor

how can you access the UI for this?

@gavofyork gavofyork merged commit efca40a into master Nov 20, 2016
@gavofyork gavofyork deleted the transactions-propagate branch November 20, 2016 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomusdrw @coveralls @gavofyork @jacogr