Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Signer to display list of locally sent transactions #3513

Closed
jacogr opened this issue Nov 18, 2016 · 1 comment
Closed

Signer to display list of locally sent transactions #3513

jacogr opened this issue Nov 18, 2016 · 1 comment
Labels
F8-enhancement 🎊 An additional feature request.

Comments

@jacogr
Copy link
Contributor

jacogr commented Nov 18, 2016

jacogr [3:22 PM]
When your PR is merged - I can use the same display (i.e. you transaction status) under the Signer tab?

tomusdrw [3:23 PM]
yes, I think so

jacogr [3:23 PM]
(Just want to see if it is possible before I log it - I have a bunch of Signer stuff up next)

tomusdrw [3:23 PM]
so the pr is basically adding two RPC methods: parity_pendingTransactionsStats and parity_localTransactions
you need to use all three to combine necessary information to render the view
pendingTransactionsStats contains Hash -> PropagationDetails
pendingTransactions contains a list of transactions (with it's details) in queue (ordered by priority)
and localTransactions returns Hash -> Status
where sometimes Status contains the whole transaction (if it's not longer in queue)
but sometimes you need to use the hash and take details of the transaction from pendingTransactions

jacogr [3:25 PM]
Ahh, ok, was wondering about that.

tomusdrw [3:25 PM]
(otherwise I would have to keep transaction data in two places and it can increase memory usage if transactions are large)

jacogr [3:26 PM]
Will adapt from you you put together in the dapp. (And will also copy this convo into the issue if I forget :))

@jacogr jacogr added F8-enhancement 🎊 An additional feature request. M7-ui labels Nov 18, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 18, 2016

@jacogr jacogr closed this as completed Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request.
Projects
None yet
Development

No branches or pull requests

1 participant