Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Light server improvements and protocol adjustments #3801

Merged
merged 7 commits into from
Dec 11, 2016
Merged

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Dec 10, 2016

  • Format requests/responses according to updated specification.
  • Request/Handshake timeouts (arbitrary values)
  • Transaction set for client
  • Reactivated dead code lint

Geth light client can now sync ropsten using parity peers:
ropsten

Mainnet is a bit more complicated since we don't support the hardcoded CHT which geth expects.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 10, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.578% when pulling acdf768 on light-import into a6fcd8a on master.

let mut stream = RlpStream::new_list(request.block_hashes.len() + 1);
stream.append(&req_id);
let mut stream = RlpStream::new_list(2);
stream.append(&req_id).begin_list(request.block_hashes.len());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec has been changed so that all requests and responses will have a variable-length list as the last item rather than having the root list be variable-length.

(personally not the way that I would go about it but geth's behavior was not per the spec and I wanted to test the server with its light client)

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 11, 2016
@arkpar arkpar merged commit 6724f57 into master Dec 11, 2016
@arkpar arkpar deleted the light-import branch January 10, 2017 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants