This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed --base-path on windows #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
gavofyork
reviewed
Jan 18, 2017
| replace_home_for_db(&data_path, &local_path, &self.args.flag_db_path) | ||
| }; | ||
| //TODO: refactor this for better detection if base_path is custom. | ||
| let base_db_path = if data_path != default_data_path() && self.args.flag_db_path == dir::CHAINS_PATH { "$BASE/chains".to_owned() } else { self.args.flag_db_path.clone() }; |
There was a problem hiding this comment.
data_path != default_data_path() looks pretty error prone... if it's a quick hack, then we should probably have an issue logged to fix it into something sensible asap.
There was a problem hiding this comment.
self.args.flag_db_path == dir::CHAINS_PATH looks pretty bad, too...
arkpar
added
A3-inprogress ⏳
arkpar
force-pushed
the
win-dir-fix
branch
2 times, most recently
from
208e35e
to
4944e42
Compare
arkpar
added
A0-pleasereview 🤓
|
Changes Unknown when pulling b615ac6 on win-dir-fix into ** on master**. |
gavofyork
added
A8-looksgood 🦄
arkpar
added a commit
that referenced
this pull request
Jan 18, 2017
* Fixed --base-path on windows * Add support for optional args with default text
arkpar
added a commit
that referenced
this pull request
Jan 19, 2017
* JsonRPC bump for IPC fix * Fixing etherscan price parsing (#4202) * Fixing etherscan price parsing * Handling all errors * Fixed --base-path on windows (#4193) * Fixed --base-path on windows * Add support for optional args with default text * Fixing minimal transaction queue price (#4204) * Fixing minimal transaction queue price * Fixing tests * verification: add mainnet BadgeReg ids (#4190) * verification: mainnet BadgeReg ids * verification: fetch contracts by name * verification: better wording * typo * reregistered badges * Console now has admin (#4220) Fixes #4210 * Non-secure for DappReg (#4216)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4191