Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Updater fixes #4196

Merged
merged 9 commits into from
Jan 17, 2017
Merged

Updater fixes #4196

merged 9 commits into from
Jan 17, 2017

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Jan 17, 2017

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jan 17, 2017
@@ -18,6 +18,7 @@ use std::sync::{Arc, Weak};
use std::fs;
use std::io::Write;
use std::path::{PathBuf};
use std::mem::drop;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already part of prelude

@rphmeier
Copy link
Contributor

The windows-based cleanup here seems kind of hacky. It ought to be possible to configure it so parity-as-a-node never runs in the same process as parity-as-a-hypervisor, even when running --force-direct or when the current exe is the latest so we can avoid this kind of stuff. Not a priority to clean up this code just yet, but it definitely needs to be done at some point.

@gavofyork gavofyork merged commit 7cab6ac into master Jan 17, 2017
@gavofyork gavofyork deleted the updater-win-fix branch January 17, 2017 22:34
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. B0-patch and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 17, 2017
arkpar added a commit that referenced this pull request Jan 18, 2017
* Minor typo to ensure it updates only when synced.

* Fix deadlock.

* Skip unneeded arg in making list.

* Allow auto-restart even when not running an update.

* Fix trace.

* Update update info on each loop.

* Fix build.

* Shutdown all sockets

* Remove superfluous use.
gavofyork pushed a commit that referenced this pull request Jan 18, 2017
* Minor typo to ensure it updates only when synced. (#4188)

* Updater fixes (#4196)

* Minor typo to ensure it updates only when synced.

* Fix deadlock.

* Skip unneeded arg in making list.

* Allow auto-restart even when not running an update.

* Fix trace.

* Update update info on each loop.

* Fix build.

* Shutdown all sockets

* Remove superfluous use.

* Poll for upgrades as part of global status (long) (#4197)

* Poll for upgrades as part of global status (long)

* Fix path

* Prevent duplicate incoming connections (#4180)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants