This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add QrCode & Copy to ShapeShift #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
suggested changes
Jan 27, 2017
| @@ -61,9 +63,7 @@ export default class AwaitingDepositStep extends Component { | |||
| } } | |||
| /> | |||
| </div> | |||
| <div className={ styles.hero }> | |||
There was a problem hiding this comment.
Is the class .hero still used anywhere ?
There was a problem hiding this comment.
Yeap. Both in AwaitingExchange & CompletedStep.
There was a problem hiding this comment.
Ah right, wasn't looking in the right folder. My bad !
ngotchac
added
A5-grumble 🔥
|
Same comment as for #4329 : don't we want to use |
|
Could make it clickable with |
|
Added
|
jacogr
added
A0-pleasereview 🤓
ngotchac
suggested changes
Jan 27, 2017
| return ( | ||
| <div className={ styles.addressInfo }> | ||
| <a | ||
| href={ `bitcoin:${depositAddress}` } |
There was a problem hiding this comment.
Shouldn't this be only for BTC transfers ?
There was a problem hiding this comment.
&^%$! So excited to have it working that I didn't pay attention.
ngotchac
added
A4-gotissues 💥
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
ngotchac
suggested changes
Jan 27, 2017
|
|
||
| return component; | ||
| } | ||
|
|
||
| describe('modals/Shapeshift/AwaitingDepositStep', () => { | ||
| describe.only('modals/Shapeshift/AwaitingDepositStep', () => { |
There was a problem hiding this comment.
Might want to get rid of this one ;)
ngotchac
added
A4-gotissues 💥
jacogr
added
A0-pleasereview 🤓
ngotchac
approved these changes
Jan 27, 2017
ngotchac
reviewed
Jan 27, 2017
| expect(qr.props().value).to.equal(TEST_ADDRESS); | ||
| }); | ||
|
|
||
| describe('protocol link', () => { |
There was a problem hiding this comment.
Is under QrCode test the right place for these tests ?
There was a problem hiding this comment.
The link wraps the QrCode. Not attached to it either way, could be outside as well.
ngotchac
added
A6-mustntgrumble 💦
jacogr
added a commit
that referenced
this pull request
Feb 3, 2017
* Extract CopyIcon to ~/ui/Icons * Add copy & QrCode address * Default size 4 * Add bitcoin: link * use protocol links applicable to coin exchanged * Remove .only
gavofyork
pushed a commit
that referenced
this pull request
Feb 4, 2017
* s/Delete Contract/Forget Contract/ (#4237) * Adjust the location of the signer snippet (#4155) * Additional building-block UI components (#4239) * Currency WIP * Expand tests * Pass className * Add QrCode * Export new components in ~/ui * s/this.props.netSymbol/netSymbol/ * Fix import case * ui/SectionList component (#4292) * array chunking utility * add SectionList component * Add TODOs to indicate possible future work * Add missing overlay style (as used in dapps at present) * Add a Playground for the UI Components (#4301) * Playground // WIP * Linting * Add Examples with code * CSS Linting * Linting * Add Connected Currency Symbol * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * Added `renderSymbol` tests * PR grumbles * Add Eth and Btc QRCode examples * 2015-2017 * Add tests for playground * Fixing tests * Split Dapp icon into ui/DappIcon (#4308) * Add QrCode & Copy to ShapeShift (#4322) * Extract CopyIcon to ~/ui/Icons * Add copy & QrCode address * Default size 4 * Add bitcoin: link * use protocol links applicable to coin exchanged * Remove .only * Display QrCode for accounts, addresses & contracts (#4329) * Allow Portal to be used as top-level modal (#4338) * Portal * Allow Portal to be used in as both top-level and popover * modal/popover variable naming * export Portal in ~/ui * Properly handle optional onKeyDown * Add simple Playground Example * Add proper event listener to Portal (#4359) * Display AccountCard name via IdentityName (#4235) * Fix signing (#4363) * Dapp Account Selection & Defaults (#4355) * Add parity_defaultAccount RPC (with subscription) (#4383) * Default Account selector in Signer overlay (#4375) * Typo, fixes #4271 (#4391) * Fix ParityBar account selection overflows (#4405) * Available Dapp selection alignment with Permissions (Portal) (#4374) * registry dapp: make lookup use lower case (#4409) * Dapps use defaultAccount instead of own selectors (#4386) * Poll for defaultAccount to update dapp & overlay subscriptions (#4417) * Poll for defaultAccount (Fixes #4413) * Fix nextTimeout on catch * Store timers * Re-enable default updates on change detection * Add block & timestamp conditions to Signer (#4411) * Extension installation overlay (#4423) * Extension installation overlay * Pr gumbles * Spelling * Update Chrome URL * Fix for non-included jsonrpc * Extend Portal component (as per Modal) #4392
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethcore/parity/issues/4238
QrCode output verified with the BlockChain.info app, able to read & translate.