Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Dapp Account Selection & Defaults #4355

Merged
merged 44 commits into from
Jan 31, 2017
Merged

Dapp Account Selection & Defaults #4355

merged 44 commits into from
Jan 31, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 30, 2017

Closes https://github.com/ethcore/parity/issues/4328

  1. Move Dapp Permissions dialog to Portal
  2. Extend selection to include default account
  3. Extend store to read & write default accounts

Implementation notes -

  1. Removed animations from the Portal - could be re-added using either tween.js (react-portal samples) or ReactCSSTransitionGroup (FB preferred) - however gave up on both of those, nice-to-have an spending an inordinate amount of time on it.
  2. Setting defaults to be done now in Signer overlay as well (https://github.com/ethcore/parity/issues/4368)

Sample -

parity 2017-01-31 12-37-18

@jacogr jacogr added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jan 30, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 31, 2017
@ngotchac
Copy link
Contributor

Might want to apply this in order for all accounts on one line to have the same height

diff --git a/js/src/modals/DappPermissions/dappPermissions.css b/js/src/modals/DappPermissions/dappPermissions.css
index 28fd9cd..8b7c03a 100644
--- a/js/src/modals/DappPermissions/dappPermissions.css
+++ b/js/src/modals/DappPermissions/dappPermissions.css
@@ -21,10 +21,12 @@
 
 .container {
   margin-top: 1.5em;
-  overflow-y: scroll;
+  overflow-y: auto;
 }
 
 .item {
+  display: flex;
+  flex: 1;
   position: relative;
 
   .overlay {
diff --git a/js/src/ui/SectionList/sectionList.css b/js/src/ui/SectionList/sectionList.css
index 4fa1bbf..0cb6dd4 100644
--- a/js/src/ui/SectionList/sectionList.css
+++ b/js/src/ui/SectionList/sectionList.css
@@ -39,8 +39,8 @@
     .item {
       box-sizing: border-box;
       cursor: pointer;
+      display: flex;
       flex: 0 1 33.33%;
-      height: 100%;
       opacity: 0.75;
       padding: 0.25em;
       transition: all 0.75s cubic-bezier(0.23, 1, 0.32, 1);


.container {
margin-top: 1.5em;
overflow-y: scroll;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to auto so we don't have unnecessary scroll bars

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 31, 2017
@ngotchac
Copy link
Contributor

Only the scroll bar is a blocking issue. For the all accounts don't have the same height on one line issue, could go either way. However it would feel more consistent with what we have currently.

@jacogr
Copy link
Contributor Author

jacogr commented Jan 31, 2017

@ngotchac I actually prefer to solve that issue another way, i.e. the AccountCard should always return the same height. The issue is with applying it, you now have rows that look uneven. Very distracting.

(With my flow-hover-pretty branch, that is exactly the route I decided to go - make sure everything always looks consistent as to not have these funnies.)

For now your solution is probably a bit better than what is these, so will apply as-is. (Will hoever log the above to look into)

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jan 31, 2017
@jacogr jacogr merged commit a935a04 into master Jan 31, 2017
@jacogr jacogr deleted the jg-dapp-default-account branch January 31, 2017 16:04
jacogr added a commit that referenced this pull request Feb 3, 2017
jacogr added a commit that referenced this pull request Feb 3, 2017
gavofyork pushed a commit that referenced this pull request Feb 4, 2017
* s/Delete Contract/Forget Contract/ (#4237)

* Adjust the location of the signer snippet (#4155)

* Additional building-block UI components (#4239)

* Currency WIP

* Expand tests

* Pass className

* Add QrCode

* Export new components in ~/ui

* s/this.props.netSymbol/netSymbol/

* Fix import case

* ui/SectionList component (#4292)

* array chunking utility

* add SectionList component

* Add TODOs to indicate possible future work

* Add missing overlay style (as used in dapps at present)

* Add a Playground for the UI Components (#4301)

* Playground // WIP

* Linting

* Add Examples with code

* CSS Linting

* Linting

* Add Connected Currency Symbol

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* Added `renderSymbol` tests

* PR grumbles

* Add Eth and Btc QRCode examples

* 2015-2017

* Add tests for playground

* Fixing tests

* Split Dapp icon into ui/DappIcon (#4308)

* Add QrCode & Copy to ShapeShift (#4322)

* Extract CopyIcon to ~/ui/Icons

* Add copy & QrCode address

* Default size 4

* Add bitcoin: link

* use protocol links applicable to coin exchanged

* Remove .only

* Display QrCode for accounts, addresses & contracts (#4329)

* Allow Portal to be used as top-level modal (#4338)

* Portal

* Allow Portal to be used in as both top-level and popover

* modal/popover variable naming

* export Portal in ~/ui

* Properly handle optional onKeyDown

* Add simple Playground Example

* Add proper event listener to Portal (#4359)

* Display AccountCard name via IdentityName (#4235)

* Fix signing (#4363)

* Dapp Account Selection & Defaults (#4355)

* Add parity_defaultAccount RPC (with subscription) (#4383)

* Default Account selector in Signer overlay (#4375)

* Typo, fixes #4271 (#4391)

* Fix ParityBar account selection overflows (#4405)

* Available Dapp selection alignment with Permissions (Portal) (#4374)

* registry dapp: make lookup use lower case (#4409)

* Dapps use defaultAccount instead of own selectors (#4386)

* Poll for defaultAccount to update dapp & overlay subscriptions (#4417)

* Poll for defaultAccount (Fixes #4413)

* Fix nextTimeout on catch

* Store timers

* Re-enable default updates on change detection

* Add block & timestamp conditions to Signer (#4411)

* Extension installation overlay (#4423)

* Extension installation overlay

* Pr gumbles

* Spelling

* Update Chrome URL

* Fix for non-included jsonrpc

* Extend Portal component (as per Modal) #4392
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants