Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode viewer #154

Closed
wants to merge 31 commits into from
Closed

Decode viewer #154

wants to merge 31 commits into from

Conversation

wirednkod
Copy link
Contributor

@wirednkod wirednkod commented Nov 7, 2023

Hey @josepot,

Last time we talked, you told me that you wanted something like this for proving how the decoder of PAPI worked.
I found it super nice and fun project, and implemented it as a side-project.

Of course this is the very first draft (see previews below)

It contains storybook (pnpm run storybook) and a sample app for decoding the hex (pnpm run dev)

What is still missing is:

  • Test more decoded scenarios and cover cases
  • Beautify CSS a bit more
  • Fix innerDocs
  • Move around the components in a way that makes sense

I can finish these things in this PR, or in a following up one... Whatever you think makes more sense

image

image

@wirednkod wirednkod changed the title Nik viewer and builder Decode viewer Nov 7, 2023
@josepot
Copy link
Member

josepot commented Nov 7, 2023

Hi @wirednkod !

I don't have the time to review this right now, I will be reviewing it tomorrow morning first thing in the morning, for sure! However, I just wanted to say from the very bottom of my heart: THANK YOU SO MUCH for always being there to lend a hand and being so proactive and helpful!

As I already mentioned: I will be reviewing this properly tomorrow. However, at a first glance I noticed a few things:

  • something odd happened with the git history? 🤔
  • the following folder examples/decode-viewer/src/stories/assets/ seems to have a bunch of unnecessary files
  • there seems to be 2 metadata files one txt and one json, do you need them both? they are quite heavy.
  • in general: could you please make sure that you remove all the unnecessary files? I think that I've seen a couple more, like one mdx file and one react.svg, etc.

Also, I want to say that despite the fact that I would have approached this a bit differently: "done >>>>>>>>> perfect" So, thank you so much! This should already enable us to test some important workflows, so this is awesome! Thanks again!

@wirednkod
Copy link
Contributor Author

I will go through your bullets and update it accordingly. This is just a first draft and we can pivot it to whatever you may want to - just tell me what needed and I can adjust it.

@wirednkod wirednkod mentioned this pull request Nov 8, 2023
4 tasks
@wirednkod
Copy link
Contributor Author

@josepot I am closing this in favour of #156 - which has a better commit history (apologies for that), a better Readme.md and removed all the unecessery files as per your advice

@wirednkod wirednkod closed this Nov 8, 2023
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-api-2023-q4-update/5318/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants