-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode viewer #154
Decode viewer #154
Conversation
Co-authored-by: Josep M Sobrepere <jm.sobrepere@gmail.com>
Hi @wirednkod ! I don't have the time to review this right now, I will be reviewing it tomorrow morning first thing in the morning, for sure! However, I just wanted to say from the very bottom of my heart: THANK YOU SO MUCH for always being there to lend a hand and being so proactive and helpful! As I already mentioned: I will be reviewing this properly tomorrow. However, at a first glance I noticed a few things:
Also, I want to say that despite the fact that I would have approached this a bit differently: "done >>>>>>>>> perfect" So, thank you so much! This should already enable us to test some important workflows, so this is awesome! Thanks again! |
I will go through your bullets and update it accordingly. This is just a first draft and we can pivot it to whatever you may want to - just tell me what needed and I can adjust it. |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-api-2023-q4-update/5318/1 |
Hey @josepot,
Last time we talked, you told me that you wanted something like this for proving how the decoder of PAPI worked.
I found it super nice and fun project, and implemented it as a side-project.
Of course this is the very first draft (see previews below)
It contains storybook (
pnpm run storybook
) and a sample app for decoding the hex (pnpm run dev
)What is still missing is:
I can finish these things in this PR, or in a following up one... Whatever you think makes more sense