Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly benchmark on_initize hook weight #184

Open
xlc opened this issue Apr 20, 2023 · 3 comments
Open

Properly benchmark on_initize hook weight #184

xlc opened this issue Apr 20, 2023 · 3 comments
Labels
I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@xlc
Copy link
Contributor

xlc commented Apr 20, 2023

Observed it is not possible to include some transaction on some block, which doesn't really make sense.

Need to do proper benchmark and return the real weight.

https://github.com/paritytech/substrate/blob/c0793b58c509f352b6006e402350ac9ad8017823/frame/session/src/lib.rs#L571

https://github.com/paritytech/substrate/blob/c0793b58c509f352b6006e402350ac9ad8017823/frame/democracy/src/lib.rs#L1625-L1626

@bkchr
Copy link
Member

bkchr commented Apr 20, 2023

CC @ggwpez

@ggwpez
Copy link
Member

ggwpez commented Apr 20, 2023

Looks like the session weight was a hack from here paritytech/substrate#5738

as suggested by shawn new_session take full block to make it easier, if in the future it is wanted we can improve on this.

Other one from paritytech/substrate#5828 is also old code rotting…

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed J0-enhancement labels Aug 25, 2023
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@bkchr
Copy link
Member

bkchr commented May 25, 2024

#4573 explains another issue that appeared because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
Development

No branches or pull requests

5 participants