Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet-xcm: waive transport fees based on XcmConfig #2082

Open
acatangiu opened this issue Oct 30, 2023 · 0 comments
Open

pallet-xcm: waive transport fees based on XcmConfig #2082

acatangiu opened this issue Oct 30, 2023 · 0 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.

Comments

@acatangiu
Copy link
Contributor

acatangiu commented Oct 30, 2023 •
edited

Problem

pallet-xcm hardcodes free message delivery when origin is the chain itself.

Solution

This can be improved by not assuming free delivery for Here, but instead rely on runtime XcmConfig::FeeManager configuration.

XcmConfig::FeeManager could be exposed to pallet-xcm and then determine delivery fees based on FeeManager::is_waived(Some(origin_ref), fee_reason).
@acatangiu acatangiu added T6-XCM This PR/Issue is related to XCM. I5-enhancement An additional feature request. labels Oct 30, 2023
@acatangiu acatangiu mentioned this issue Oct 30, 2023
Merged
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
Add more logs to relayer and message pallets (paritytech#2082)
5d77cd7 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
Add more logs to relayer and message pallets (paritytech#2082)
0702477 
* add more logs

* unused import

* fmt
@acatangiu acatangiu added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 28, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
Add more logs to relayer and message pallets (paritytech#2082)
0fde4f9 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
9c69125 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
585bae4 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
025e13a 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
3572c7a 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
2753c7f 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
2058e80 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
ffd03ef 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
750faaa 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
7f9f776 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
81e9e94 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
62327f8 
* add more logs

* unused import

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Add more logs to relayer and message pallets (paritytech#2082)
ca2067f 
* add more logs

* unused import

* fmt
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Add more logs to relayer and message pallets (#2082)
c17f625 
* add more logs

* unused import

* fmt
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this issue May 27, 2024
@svyatonik @TomaszWaszczyk
Add more logs to relayer and message pallets (paritytech#2082)
2331186 
* add more logs

* unused import

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.
Projects
Parity Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acatangiu