Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file structure #590

Open
xlc opened this issue Aug 1, 2023 · 5 comments
Open

Improve file structure #590

xlc opened this issue Aug 1, 2023 · 5 comments
Assignees
@GauravDhak
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.

Comments

@xlc
Copy link
Contributor

xlc commented Aug 1, 2023

We have too many files are more than 1000 lines of code, which is a bad code smell.

For example, https://github.com/paritytech/polkadot/blob/master/runtime/common/src/auctions.rs
the tests should be its own file as well as benchmarks.
@GauravDhak
Copy link

i want to work on this issue can you assign me

@ggwpez
Copy link
Member

ggwpez commented Aug 7, 2023 •
edited

We should wait with large refactors until the monorepo migration finishes on 28th.
Please dont start working on it before that.

@GauravDhak
Copy link

👍

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I8-refactor labels Aug 25, 2023
@shawntabrizi
Copy link
Contributor

@GauravDhak should be ready to work on this kind of stuff now.

@the-right-joyce this should be marked easy and good first issue

@bkchr bkchr added the D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. label Mar 11, 2024
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 11, 2024
@GauravDhak
Copy link

I am interested in working on this issue. That's great!

serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
5f95945 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
5ffc338 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
73eb730 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
a2a9fc8 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
3a31dbb 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
34ca3de 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
29b4ff3 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
e8daba3 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
392c310 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
7eec33e 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
a1f5f91 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Automated weights for message lane module (paritytech#590)
7ee3121 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Automated weights for message lane module (#590)
e5f6e30 
* automated weights

* associated WeightInfo type

* update weights using wasmtime

* disable clippy for autogenerated weight.rs

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GauravDhak GauravDhak

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xlc @shawntabrizi @bkchr @ggwpez @the-right-joyce @GauravDhak