Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVF: Preparation in advance #684

Closed
mrcnski opened this issue Mar 23, 2023 · 1 comment
Closed

PVF: Preparation in advance #684

mrcnski opened this issue Mar 23, 2023 · 1 comment

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Mar 23, 2023 •
edited
Loading

ISSUE

Overview

Possibly prepare PVFs in advance?

Issue extracted from discussion in paritytech/polkadot#6551 (review). Let's continue here to unblock that PR.

Previous discussion

We do not currently have any "I'm taking a long time" messages, so if we send out approval assignments but do artifact builds lazily, then we'll cause no shows, given that builds can take more than the 12? second no show time out.

In theory, we could send messages for "building artifact" and/or "It's slow but I'm here", but @rphmeier wanted to avoid complicating the approval process with such messages, probably a wise decision. We therefore need PVF artifacts to be built in advance, or else we suck up the risk of correlated artifact builds creating de fact escalations.

Originally posted by @burdges in paritytech/polkadot#6551 (comment)

Indeed, I was wondering about this a couple of times already myself. I think for the time being, preparation is usually pretty fast so there are no issues.

The problem with preparation in advance is, that this will likely result in wasted effort in case of parathreads. As all validators would need to prepare a PVF, although only 30 approval checkers will actually need it. Might be fine.

Other options:

  1. Gather some data on actual preparation times - if they turn out to be very low, we could just enforce a reasonably low value in pre-checking.
  2. Interpret parathread PVFs instead of compiling. Given that they are expected to be executed only rarely, the compiliation effort is likely not worth the trouble anyway. (And for parachains prepare in advance)

Originally posted by @eskimor in paritytech/polkadot#6551 (comment)

See link above for the rest of the discussion.

Related issue

#685 (Avoid clearing the artifacts cache on restart)
This was referenced Mar 23, 2023
Closed
Merged
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden added a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@claravanstaden
Implements MaxEncodedLen for beacon client (paritytech#684)
820ec5d 
* Progress on MaxEncodedLen.

* Rename generics to actual words since characters dont make sense anymore

* Wading through compiler errors...

* Cleans up constants

* Separate structs using Serialize and maxEncodedLen

* Progress

* Finish up with MaxEncodedLen work

* Cleanup.

* Fix whitespace

* Missed whitespace.

* More whitespace.

* Alias bounded structs. Minor cleanup.

* Public aliases.
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@dependabot
Bump lru from 0.6.6 to 0.7.5 (paritytech#684)
5077d40 
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.6.6 to 0.7.5.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](jeromefroe/lru-rs@0.6.6...0.7.5)

---
updated-dependencies:
- dependency-name: lru
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
8ac55b2 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
2f09938 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
2073167 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
d2179be 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
6480a3a 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
c4095b7 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
03156bf 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
3f7d524 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
26e419f 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
028d99d 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
4d1fb2b 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@HCastano @tomusdrw @serban300
Bump Substrate Dependency (paritytech#684)
5a79eba 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
bkchr pushed a commit that referenced this issue Apr 10, 2024
@HCastano @tomusdrw @bkchr
Bump Substrate Dependency (#684)
ac1d12e 
* Bump Substrate to commit `0b0d124d5`

* Get Millau node compiling

* Get Rialto node compiling

* Increase account reference count before test

* Fix Clippy warnings for Millau node

* Fix Clippy warnings for Rialto node

* Trigger build.

Co-authored-by: Tomasz Drwięga <tomasz@parity.io>
@eskimor
Copy link
Member

eskimor commented Jul 13, 2024

Closing, we have other issues for this.

@eskimor eskimor closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eskimor @mrcnski @the-right-joyce