Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review calls requires root origins and determine if we can reduce the requirement #717

Open
xlc opened this issue Feb 13, 2023 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.

Comments

@xlc
Copy link
Contributor

xlc commented Feb 13, 2023

Right now many calls requires root origin such as register.swap.

Due to design of OpenGov that root track can only have one referendum at a time. This means it is not possible to have two independent referenda from two parachain teams.

It makes perfect sense to have multiple concurrent register.swap proposal, as parachain leases are done in a batch. So we should make the admin origin for register pallet configurable and adjust OpenGov track accordingly.

While we are at it, we might as well review other calls that require root origin and determine if it is necessary.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@xlc
Copy link
Contributor Author

xlc commented Sep 1, 2023

Another low damage but critical operational call is disputes.force_unfreeze. For such low damage calls, they don't need the protection of root origin and we should be able to dispatch them faster.

@olanod
Copy link
Contributor

olanod commented Sep 1, 2023

I asked this a while back, I would even go as far as deprecating ensure_root and always be explicit with specialized origins.

claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com>
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I4-refactor Code needs refactoring. labels Mar 13, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* fix max weight in relay + logging

* removed duplicate info
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* fix max weight in relay + logging

* removed duplicate info
bkchr pushed a commit that referenced this issue Apr 10, 2024
* fix max weight in relay + logging

* removed duplicate info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

3 participants