Make System Parachains trusted Teleporters #1368

NachoPal · 2023-09-02T18:10:39Z

Make System Parachain trusted Teleporters of each other.

NachoPal · 2023-09-02T18:10:58Z

bot fmt

command-bot · 2023-09-02T18:11:02Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3539442 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-c112365f-e429-415a-8ec4-5b367616c14e to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-02T18:14:27Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3539442 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3539442/artifacts/download.

NachoPal · 2023-09-04T11:20:44Z

bot fmt

command-bot · 2023-09-04T11:20:49Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3551152 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-8f2eee7a-1c6a-472e-9603-7fda842bda69 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-04T11:22:03Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3551152 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3551152/artifacts/download.

cumulus/parachains/common/src/xcm_config.rs

KiChjang · 2023-09-05T20:50:48Z

Not sure if you also want to address #100 as well in this PR.

cumulus/parachains/integration-tests/emulated/assets/asset-hub-rococo/src/tests/mod.rs

cumulus/parachains/common/src/xcm_config.rs

NachoPal · 2023-09-06T10:11:44Z

Not sure if you also want to address #100 as well in this PR.

You mean to do something like this?

pub struct IsSiblingParachainAsset<SelfParaId>(sp_std::marker::PhantomData<SelfParaId>);
impl<SelfParaId: Get<ParaId>> ContainsPair<MultiAsset, MultiLocation>
	for IsSiblingParachainAsset<SelfParaId>
{
	fn contains(asset: &MultiAsset, origin: &MultiLocation) -> bool {
		log::trace!(target: "xcm::contains", "IsSiblingParachainAsset asset: {:?}, origin: {:?}", asset, origin);
		matches!(asset.id, Concrete(ref id) if <FromSiblingParachain<SelfParaId>>::contains(id, origin))
	}
}

KiChjang · 2023-09-06T13:16:25Z

@NachoPal Yes, I think that's about right. The idea is to cut away unnecessary type parameters.

NachoPal · 2023-09-06T13:51:56Z

@NachoPal Yes, I think that's about right. The idea is to cut away unnecessary type parameters.

Ok, as IsForeignConcreteAsset<FromSiblingParachain<parachain_info::Pallet<Runtime>>> has not been introduced in this PR, if it is ok, I prefer to open a new one to close #100 to avoid mixing unrelated changes.

...parachains/integration-tests/emulated/collectives/collectives-polkadot/src/tests/teleport.rs

cumulus/parachains/integration-tests/emulated/common/src/macros.rs

…tytech/polkadot-sdk into nacho/make-system-paras-teleporters

NachoPal · 2023-10-16T09:59:07Z

bot fmt

command-bot · 2023-10-16T09:59:13Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3968051 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 44-cfe9799f-8de8-4f75-b5b7-b9b76b65b89f to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-16T10:03:18Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3968051 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3968051/artifacts/download.

cumulus/parachains/integration-tests/emulated/common/src/macros.rs

cumulus/parachains/common/src/xcm_config.rs

cumulus/parachains/integration-tests/emulated/assets/asset-hub-westend/src/tests/teleport.rs

ordian · 2023-10-16T15:49:42Z

cumulus/parachains/integration-tests/emulated/assets/asset-hub-rococo/src/lib.rs

+pub use xcm_emulator::{assert_expected_events, bx, Chain, Parachain, TestExt};
+
+#[cfg(test)]
+#[cfg(not(feature = "runtime-benchmarks"))]


why doesn't it work with runtime-benchmarks feature? AFAIK, we only run tests with the feature enabled in CI

Thanks for noticing, it wasn't like that before: #1335

Make System Parachain trusted Teleporters of each other. Migration of paritytech/cumulus#2842 --------- Co-authored-by: command-bot <> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

migrate cumulus #2842

5992995

NachoPal requested review from joepetrowski, gilescope and KiChjang and removed request for KiChjang September 2, 2023 18:11

paritytech-ci requested review from a team September 2, 2023 18:12

NachoPal added the T14-system_parachains This PR/Issue is related to system parachains. label Sep 2, 2023

".git/.scripts/commands/fmt/fmt.sh"

935a95d

fix conflicts

5a3cebf

".git/.scripts/commands/fmt/fmt.sh"

a6191b7

gilescope reviewed Sep 5, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Show resolved Hide resolved

gilescope approved these changes Sep 5, 2023

View reviewed changes

KiChjang reviewed Sep 5, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Outdated Show resolved Hide resolved

KiChjang reviewed Sep 5, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Outdated Show resolved Hide resolved

joepetrowski previously requested changes Sep 6, 2023

View reviewed changes

cumulus/parachains/integration-tests/emulated/assets/asset-hub-rococo/src/tests/mod.rs Outdated Show resolved Hide resolved

comments

0268b19

bkontur reviewed Sep 6, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Outdated Show resolved Hide resolved

joepetrowski reviewed Sep 7, 2023

View reviewed changes

...parachains/integration-tests/emulated/collectives/collectives-polkadot/src/tests/teleport.rs Outdated Show resolved Hide resolved

joepetrowski reviewed Sep 7, 2023

View reviewed changes

cumulus/parachains/integration-tests/emulated/common/src/macros.rs Outdated Show resolved Hide resolved

NachoPal added 4 commits October 8, 2023 16:37

Merge branch 'nacho/make-system-paras-teleporters' of github.com:pari…

c358525

…tytech/polkadot-sdk into nacho/make-system-paras-teleporters

merge master

7f5f6ce

remove prod runtimes and clean up

a111b4b

remove westend colletives & bidge

0d93435

NachoPal mentioned this pull request Oct 16, 2023

Make System Parachains trusted Teleporters polkadot-fellows/runtimes#62

Closed

acatangiu approved these changes Oct 16, 2023

View reviewed changes

cumulus/parachains/integration-tests/emulated/common/src/macros.rs Show resolved Hide resolved

NachoPal added 7 commits October 16, 2023 12:43

fix conflicts

0e0ca41

fix conflicts 2

5b3638d

fmt

4c1c8e1

fix conflicts 3

3414a52

fmt

ca30c50

add asset-hub-rococo to cargo.toml

7c40b8c

fix

4c49811

kianenigma reviewed Oct 16, 2023

View reviewed changes

cumulus/parachains/common/src/xcm_config.rs Outdated Show resolved Hide resolved

kianenigma reviewed Oct 16, 2023

View reviewed changes

cumulus/parachains/integration-tests/emulated/assets/asset-hub-westend/src/tests/teleport.rs Outdated Show resolved Hide resolved

kianenigma approved these changes Oct 16, 2023

View reviewed changes

paritytech-ci requested a review from a team October 16, 2023 15:11

ordian reviewed Oct 16, 2023

View reviewed changes

ordian approved these changes Oct 16, 2023

View reviewed changes

address comments

d52181d

NachoPal merged commit e0065cb into master Oct 16, 2023
110 of 111 checks passed

NachoPal deleted the nacho/make-system-paras-teleporters branch October 16, 2023 17:52

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 10, 2023

adapt paritytech/polkadot-sdk#1368

24395d7

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 22, 2023

also mention paritytech/polkadot-sdk#1368 in changelog

99edee1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make System Parachains trusted Teleporters #1368

Make System Parachains trusted Teleporters #1368

NachoPal commented Sep 2, 2023 •

edited by gilescope

NachoPal commented Sep 2, 2023

command-bot bot commented Sep 2, 2023 •

edited

command-bot bot commented Sep 2, 2023

NachoPal commented Sep 4, 2023

command-bot bot commented Sep 4, 2023 •

edited

command-bot bot commented Sep 4, 2023

KiChjang commented Sep 5, 2023

NachoPal commented Sep 6, 2023

KiChjang commented Sep 6, 2023

NachoPal commented Sep 6, 2023 •

edited

NachoPal commented Oct 16, 2023

command-bot bot commented Oct 16, 2023 •

edited

command-bot bot commented Oct 16, 2023

ordian Oct 16, 2023

NachoPal Oct 16, 2023

Make System Parachains trusted Teleporters #1368

Make System Parachains trusted Teleporters #1368

Conversation

NachoPal commented Sep 2, 2023 • edited by gilescope

NachoPal commented Sep 2, 2023

command-bot bot commented Sep 2, 2023 • edited

command-bot bot commented Sep 2, 2023

NachoPal commented Sep 4, 2023

command-bot bot commented Sep 4, 2023 • edited

command-bot bot commented Sep 4, 2023

KiChjang commented Sep 5, 2023

NachoPal commented Sep 6, 2023

KiChjang commented Sep 6, 2023

NachoPal commented Sep 6, 2023 • edited

NachoPal commented Oct 16, 2023

command-bot bot commented Oct 16, 2023 • edited

command-bot bot commented Oct 16, 2023

ordian Oct 16, 2023

Choose a reason for hiding this comment

NachoPal Oct 16, 2023

Choose a reason for hiding this comment

NachoPal commented Sep 2, 2023 •

edited by gilescope

command-bot bot commented Sep 2, 2023 •

edited

command-bot bot commented Sep 4, 2023 •

edited

NachoPal commented Sep 6, 2023 •

edited

command-bot bot commented Oct 16, 2023 •

edited