Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup repo (a tiny bit) #1382

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Cleanup repo (a tiny bit) #1382

merged 6 commits into from
Sep 4, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 4, 2023

Saw some random unmaintained files… outdated docs do more harm than good IMO.
The repo could use some proper scrubbing but i only deleted the ones that i bumped into for now.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Sep 4, 2023
@paritytech-ci paritytech-ci requested a review from a team September 4, 2023 09:44
@@ -1,24 +0,0 @@
# Basic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serban300
could you, please, exclude this file from verify-pallets-build.sh in bridges repo?
Just to avoid bringing it back on the next subtree update.

Anyway, I will file a issue soon for moving bridges to the monorepo and move subtree from cumulus subdirectory out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will do.

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to ignore *.adoc. There are probably not many left.
Thanks for the cleanup !

@@ -7,6 +7,7 @@
.local
.vscode
.wasm-binaries
*.adoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not ignore the adoc files but removing them as you did is great.

Most are very old.

A (long) while ago, I introduced adoc to substrate mainly because it supports include.

A point was made however back then: Rust means Markdown and there is no foreseen support for adoc so using adoc for the documentation of a Rust project adds some burden that it not worth going thru when we ned a simple README.

Copy link
Member Author

@ggwpez ggwpez Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all adocs. The gitignore was meant as a warning for devs to not accidentially commit adocs again 😄 (since git prints something if you try to commit a gitignored file)

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez enabled auto-merge (squash) September 4, 2023 11:56
@ggwpez ggwpez merged commit 2f242e0 into master Sep 4, 2023
100 of 108 checks passed
@ggwpez ggwpez deleted the oty-adoc-convert-to-md branch September 4, 2023 12:45
@ggwpez ggwpez mentioned this pull request Sep 7, 2023
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
* Delete stale adoc files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Convert adoc to md

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add adoc to gitignore

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Delete more random unmaintained files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Markdown lint

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Delete stale adoc files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Convert adoc to md

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add adoc to gitignore

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Delete more random unmaintained files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Markdown lint

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* Delete stale adoc files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Convert adoc to md

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add adoc to gitignore

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Delete more random unmaintained files

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Markdown lint

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants