asset-rate pallet: box asset kind parameter #1545

muharem · 2023-09-13T15:35:35Z

The AssetKind type parameter of a dispatchable, defined by the user, might be large — like xcm::MultiLocation. To prevent inflating the size of the Call type, we Box it.

This changes required for #1333

ggwpez

There are some un-needed clones, but looking good in general.

substrate/frame/asset-rate/src/lib.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

muharem · 2023-09-14T10:49:55Z

@ggwpez can you look again please.
I also updated traits ConversionFromAssetBalance and ConversionToAssetBalance accept AssetId as ref to avoid extra clone. I will update the PR title if looks good to you.

muharem · 2023-09-14T10:51:20Z

probably better to have separate PR for the traits

ggwpez · 2023-09-14T10:54:44Z

@ggwpez can you look again please. I also updated traits ConversionFromAssetBalance and ConversionToAssetBalance accept AssetId as ref to avoid extra clone. I will update the PR title if looks good to you.

Historically the converters use instances and not references, eg like in the Convert trait.
I think it makes sense to keep that, since the functions are called to_asset_balance, which indicated consumption of the argument (as compared to as_asset_balance).

This reverts commit b84b809.

This reverts commit e64fba7.

muharem · 2023-09-14T11:08:37Z

@ggwpez reverted

muharem · 2023-09-14T13:39:45Z

@ggwpez can you reapprove if looks good, I did reset the previous approve from you.

Polkadot-Forum · 2023-10-27T17:04:24Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/1

The `AssetKind` type parameter of a dispatchable, defined by the user, might be large — like `xcm::MultiLocation`. To prevent inflating the size of the `Call` type, we `Box` it. This changes required for paritytech#1333 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

…tytech#1545) * generated_message_details() -> Simplifications - avoid using a HashMap for `messages_to_refine`. It seems that a vec is enough - minimize the number of conversions between `OutboundMessageDetails` and `MessageDetails` - use references where possible in order to minimize the number of intermediary Vecs - simplify `make_message_details_map()` logic, reduce its scope and rename it to `validate_out_msgs_details()` Signed-off-by: Serban Iorga <serban@parity.io> * Define typed_state_call() Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with single messages Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with batched messages Signed-off-by: Serban Iorga <serban@parity.io> * validate_out_msgs_details() -> change check * Define split_msgs_to_refine() Signed-off-by: Serban Iorga <serban@parity.io> Signed-off-by: Serban Iorga <serban@parity.io>

* generated_message_details() -> Simplifications - avoid using a HashMap for `messages_to_refine`. It seems that a vec is enough - minimize the number of conversions between `OutboundMessageDetails` and `MessageDetails` - use references where possible in order to minimize the number of intermediary Vecs - simplify `make_message_details_map()` logic, reduce its scope and rename it to `validate_out_msgs_details()` Signed-off-by: Serban Iorga <serban@parity.io> * Define typed_state_call() Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with single messages Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with batched messages Signed-off-by: Serban Iorga <serban@parity.io> * validate_out_msgs_details() -> change check * Define split_msgs_to_refine() Signed-off-by: Serban Iorga <serban@parity.io> Signed-off-by: Serban Iorga <serban@parity.io>

…tytech#1545) * generated_message_details() -> Simplifications - avoid using a HashMap for `messages_to_refine`. It seems that a vec is enough - minimize the number of conversions between `OutboundMessageDetails` and `MessageDetails` - use references where possible in order to minimize the number of intermediary Vecs - simplify `make_message_details_map()` logic, reduce its scope and rename it to `validate_out_msgs_details()` Signed-off-by: Serban Iorga <serban@parity.io> * Define typed_state_call() Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with single messages Signed-off-by: Serban Iorga <serban@parity.io> * Call To*InboundLaneApi::message_details() with batched messages Signed-off-by: Serban Iorga <serban@parity.io> * validate_out_msgs_details() -> change check * Define split_msgs_to_refine() Signed-off-by: Serban Iorga <serban@parity.io> Signed-off-by: Serban Iorga <serban@parity.io>

box asset kind paramater for asset-rate pallet dispatchables

064525d

muharem added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. labels Sep 13, 2023

muharem marked this pull request as ready for review September 14, 2023 09:39

muharem requested review from a team and removed request for a team September 14, 2023 09:39

ggwpez approved these changes Sep 14, 2023

View reviewed changes

substrate/frame/asset-rate/src/lib.rs Outdated Show resolved Hide resolved

substrate/frame/asset-rate/src/lib.rs Outdated Show resolved Hide resolved

muharem and others added 3 commits September 14, 2023 12:21

Apply suggestions from code review

4822e77

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

pass as reference

7e13f4c

pass asset id as ref for ConversionFromAssetBalance

e64fba7

muharem requested a review from ggwpez September 14, 2023 10:41

pass asset id as ref for ConversionToAssetBalance

b84b809

paritytech-ci requested review from a team September 14, 2023 10:49

muharem added 2 commits September 14, 2023 13:02

Revert "pass asset id as ref for ConversionToAssetBalance"

fc696b0

This reverts commit b84b809.

Revert "pass asset id as ref for ConversionFromAssetBalance"

028c9a4

This reverts commit e64fba7.

juangirini approved these changes Sep 14, 2023

View reviewed changes

Merge branch 'master' into muharem-asset-rate-box-parameter

36a929a

muharem mentioned this pull request Sep 15, 2023

Treasury spends various asset kinds #1333

Merged

ggwpez approved these changes Sep 15, 2023

View reviewed changes

muharem merged commit 841a33e into master Sep 15, 2023
110 checks passed

muharem deleted the muharem-asset-rate-box-parameter branch September 15, 2023 09:52

muharem added the T4-runtime_API This PR/Issue is related to runtime APIs. label Sep 18, 2023

kiltbot mentioned this pull request Oct 19, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

asset-rate pallet: box asset kind parameter #1545

asset-rate pallet: box asset kind parameter #1545

muharem commented Sep 13, 2023 •

edited

ggwpez left a comment

muharem commented Sep 14, 2023 •

edited

muharem commented Sep 14, 2023

ggwpez commented Sep 14, 2023

muharem commented Sep 14, 2023

muharem commented Sep 14, 2023

Polkadot-Forum commented Oct 27, 2023

asset-rate pallet: box asset kind parameter #1545

asset-rate pallet: box asset kind parameter #1545

Conversation

muharem commented Sep 13, 2023 • edited

ggwpez left a comment

Choose a reason for hiding this comment

muharem commented Sep 14, 2023 • edited

muharem commented Sep 14, 2023

ggwpez commented Sep 14, 2023

muharem commented Sep 14, 2023

muharem commented Sep 14, 2023

Polkadot-Forum commented Oct 27, 2023

muharem commented Sep 13, 2023 •

edited

muharem commented Sep 14, 2023 •

edited