Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added review-bot to fine tune review requirements #1673

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Commits on Sep 22, 2023

  1. add review-bot to fine tune pr reviewers

    Created a Github Action that uses the [Review-Bot app](https://github.com/paritytech/review-bot) to require more fine tuned requirements to review pull requests before allowing the PR to be merged.
    
    This uses [`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) for the event, not `pull_request`. This is a security measure so that an attacker doesn’t have access to the secrets.
    Bullrich committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4b04a77 View commit details
    Browse the repository at this point in the history
  2. added custom rule for audit team

    Added rule which allows the audit team to lock particular important changes when they were created by someone who does not belong to the core-devs team
    
    This resolves paritytech/pr-custom-review#136
    Bullrich committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    2b4e3cb View commit details
    Browse the repository at this point in the history
  3. protected review bot file

    Added protection to review bot file which would keep this file from being modified by unknown parties. Added `opstooling` as a required team to ensure that this file does not break
    Bullrich committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f9cc570 View commit details
    Browse the repository at this point in the history
  4. applied last updates

    Bullrich committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8172405 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. modified approvals in audit rule from 2 to 1

    Co-authored-by: Joyce Siqueira <98593770+the-right-joyce@users.noreply.github.com>
    Bullrich and the-right-joyce committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c0411c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    4532bd9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72d97e6 View commit details
    Browse the repository at this point in the history