Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

drskalman · 2023-10-08T00:49:04Z

Next step in process of making BEEFY being able to generate both ECDSA and BLS signature after #1705. It allows BEEFY to use a pair of ECDSA and BLS key as a AuthorityId.

…ssfuly try to implement ByteArray for paired crypto Public

…ed crypto object in favor of avoiding copy

…me of aux traits for `paired_crypto::Signature`

… of seeds for paired crypto scheme.

…paired (ECDSA, BLS377) crypto

…_crypto.rs`. - put serialize and descerialze under `serde` feature instead of std. - in `primitives/core/src/bls.rs`. - fix documentation in `primitives/core/src/bls.rs`. - cargo fmt pair_crypto.rs

…and SCALE. Co-authored-by: Davide Galassi <davxy@datawok.net>

Co-authored-by: Davide Galassi <davxy@datawok.net>

…ZED_SIZE` instead of magic numbers

- Remove `SignaturePair` trait. - Skip encoding redundant copy of paired::Public and Signature and implement Decode

…red_crypto::Pair

…rypto type - Implement ecdsa_bls37_crypto for BEEFY primitives.

Polkadot-Forum · 2023-10-17T13:10:04Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/6

…y-primitives

davxy · 2023-10-19T06:22:06Z

@drskalman Can you remind me what is the condition to remove experimental? We want to switch to 381?

davxy

At some point we need to refactor all this crypto stuff. Too much duplicated code

Edit: implementations of new stuff is missing from the local keystore implementation

davxy · 2023-10-19T06:38:58Z

substrate/primitives/consensus/beefy/src/lib.rs

@@ -140,6 +140,45 @@ pub mod bls_crypto {
 		}
 	}
 }
+
+/// BEEFY cryptographic types for (ECDSA,BLS) crypto pair


Why here you've not specified BLS12-377?
This will be changed to use 381?

Possibly.

The BLS in the BLS12 curves and BLS in the signature are not the same thing though. (I think only the L in the BLS signature and in the BLS12 curves are the same person). You could do BLS signature with any other BLS friendly curves such as BN or BLS24. Here I just wanted to say that we are generating a BLS type signature without going into the technicality of which curve we are using under the hood.

But here we are not defining types which are bounded by a generic pairing fiendly curve to produce BLS signatures. Here we are using a specific curve (which at the moment is bls12-377). And the same applies to bls_crypto module.

So maybe the question now is: is intentional to not be explicit about the curve in the modules names?

I'm not saying that this is not the right choice. I'm just curious

drskalman · 2023-10-20T08:43:09Z

Edit: implementations of new stuff is missing from the local keystore implementation

Done!

drskalman · 2023-10-20T09:00:26Z

@drskalman Can you remind me what is the condition to remove experimental? We want to switch to 381?

This requires that we generate the Web3sum proofs on BW6-767 instead of what currently is don on BW6-767:

The APK proof library is currently hard coded on using BLS-377 and BW6-761.
BW6-761 scaler field is more Fourier transform friendly. We have a good enough Fourier transform for BW6-767 but I don't think it is merged upstream, tested, benchmarked etc.
We need to run a power of tau cermony for BW6-767 before we are able to use it.

Alterantively we could compute the APK Proof Snarks in non-native field but that need quite a bit of re-implementation of apk proof library.

I'm not sure how long it will take for either of these approaches to be implemented and I'm hoping while waiting for these to get implemented at least we could have a test relay on a testnet by using bls12-377 for now.

Suggested-by: Davide Galassi <davxy@datawok.net>

Lederstrumpf

LGTM! 👍

…y-primitives

* master: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)

* tsv-disabling: Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008)

* tsv-disabling: (36 commits) Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008) Refactor candidates test in paras_inherent (#2004) PVF: Add worker check during tests and benches (#1771) Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997) polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002) Make `IdentityInfo` generic in `pallet-identity` (#1661) Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900) `CheckWeight`: Add more logging (#1996) ...

…1815) Next step in process of making BEEFY being able to generate both ECDSA and BLS signature after #1705. It allows BEEFY to use a pair of ECDSA and BLS key as a AuthorityId. --------- Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Robert Hambrock <roberthambrock@gmail.com>

Polkadot-Forum · 2023-11-28T12:52:43Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/7

…aritytech#1815) Next step in process of making BEEFY being able to generate both ECDSA and BLS signature after paritytech#1705. It allows BEEFY to use a pair of ECDSA and BLS key as a AuthorityId. --------- Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: Robert Hambrock <roberthambrock@gmail.com>

drskalman and others added 25 commits September 25, 2023 15:29

First definition for pair public keys

5d3dce1

Two example of implementation of pair for demonestration

be890d4

- implement paired crypto Public as tuple of two Publics - unsuce…

fb6a018

…ssfuly try to implement ByteArray for paired crypto Public

keep both public key object and their continous serialization in pair…

62ef8b1

…ed crypto object in favor of avoiding copy

implement PassBy and From<Pair> for paired_crypto

8d4e523

implement rest of aux traits for paired_crypto::Public implement so…

eea74e2

…me of aux traits for `paired_crypto::Signature`

Attempt to implement trait Pair for pair_cyrpto::Pair

f407d87

- Implement trait Pair for paired_crypto::Pair - Implement a pair…

2606cc4

… of seeds for paired crypto scheme.

implement sgin and verify for

00933da

Actually implementing paired_crypto::{Pair, Public, Signatrue} for …

e7719ab

…paired (ECDSA, BLS377) crypto

Implement and pass all test for paired_crypto

7a9b677

- move to signle seed for both schemes in `primitives/core/src/paired…

a01a814

…_crypto.rs`. - put serialize and descerialze under `serde` feature instead of std. - in `primitives/core/src/bls.rs`. - fix documentation in `primitives/core/src/bls.rs`. - cargo fmt pair_crypto.rs

replace hex! → array_bytes::hex2xx

7c02658

Apply suggestions from paired_crypto code review on type nam, hash …

7f8d958

…and SCALE. Co-authored-by: Davide Galassi <davxy@datawok.net>

Do not panic in paired::Signature::try_from

eef2cec

Co-authored-by: Davide Galassi <davxy@datawok.net>

Remove DoublePair trait.

efb215f

Co-authored-by: Davide Galassi <davxy@datawok.net>

Do not empty implement paired::Pair

65584bd

Co-authored-by: Davide Galassi <davxy@datawok.net>

Use paired_crypto::Seed instead of [u8; SECURE_SEED_LEN]

e047f75

Co-authored-by: Davide Galassi <davxy@datawok.net>

use ecdsa::PUBLIC_KEY_SERIALIZED_SIZE and `ecdsa::SIGNATURE_SERIALI…

c12b82e

…ZED_SIZE` instead of magic numbers

Remove paired::DoublePair impl as well

dba854a

- Implement BytesArray for both ecdsa and bls Signatures

5182c86

- Remove `SignaturePair` trait. - Skip encoding redundant copy of paired::Public and Signature and implement Decode

Implement encode_and_decode_(public_key/signature)_works test for pai…

17d0077

…red_crypto::Pair

cargo fmt

a740589

- Implement RuntimeAppCrypto and necessery hostApi for ecdsa_bls377 c…

79f25e9

…rypto type - Implement ecdsa_bls37_crypto for BEEFY primitives.

cargo fmt

067dece

drskalman added 2 commits October 17, 2023 12:37

Merge branch 'master' into skalman--paired-ecdsa-bls-support-for-beef…

3cf7594

…y-primitives

cargo fmt

652990e

Lederstrumpf requested review from Lederstrumpf and davxy October 17, 2023 17:07

Lederstrumpf added the T0-node This PR/Issue is related to the topic “node”. label Oct 17, 2023

Nitpicks

388ed14

davxy approved these changes Oct 19, 2023

View reviewed changes

davxy self-requested a review October 19, 2023 07:32

implement ecdsa_bls377 Keystore functions for LocalKeystore.

9f07bd5

davxy approved these changes Oct 20, 2023

View reviewed changes

Lederstrumpf added 2 commits October 24, 2023 15:06

nitpick tuple consistency

fdd1bdf

Suggested-by: Davide Galassi <davxy@datawok.net>

reuse Ord impl for PartialOrd impl of Public

305a003

Lederstrumpf approved these changes Oct 24, 2023

View reviewed changes

Lederstrumpf enabled auto-merge (squash) October 24, 2023 17:59

Merge branch 'master' into skalman--paired-ecdsa-bls-support-for-beef…

3a8c46e

…y-primitives

Lederstrumpf merged commit fbd5777 into paritytech:master Oct 24, 2023
107 of 110 checks passed

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Open

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

drskalman mentioned this pull request Nov 27, 2023

Make BEEFY able to generate data needed for Web3Sum proof generation w3f/polkadot-sdk#3

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

drskalman commented Oct 8, 2023

Polkadot-Forum commented Oct 17, 2023

davxy commented Oct 19, 2023

davxy left a comment •

edited

davxy Oct 19, 2023

drskalman Oct 23, 2023

davxy Oct 23, 2023 •

edited

drskalman commented Oct 20, 2023

drskalman commented Oct 20, 2023

Lederstrumpf left a comment

Polkadot-Forum commented Nov 28, 2023

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

Conversation

drskalman commented Oct 8, 2023

Polkadot-Forum commented Oct 17, 2023

davxy commented Oct 19, 2023

davxy left a comment • edited

Choose a reason for hiding this comment

davxy Oct 19, 2023

Choose a reason for hiding this comment

drskalman Oct 23, 2023

Choose a reason for hiding this comment

davxy Oct 23, 2023 • edited

Choose a reason for hiding this comment

drskalman commented Oct 20, 2023

drskalman commented Oct 20, 2023

Lederstrumpf left a comment

Choose a reason for hiding this comment

Polkadot-Forum commented Nov 28, 2023

davxy left a comment •

edited

davxy Oct 23, 2023 •

edited