Ensure correct variant count in `Runtime[Hold/Freeze]Reason` #1900

kianenigma · 2023-10-17T07:21:54Z

Breaking Changes

This PR introduces a new item to pallet_balances::Config:

trait Config {
++    type RuntimeFreezeReasons;
}

This value is only used to check it against type MaxFreeze. A similar check has been added for MaxHolds against RuntimeHoldReasons, which is already given to pallet_balances.

In all contexts, you should pass the real RuntimeFreezeReasons generated by construct_runtime to type RuntimeFreezeReasons. Passing () would also work, but it would imply that the runtime uses no freezes at all.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez

If we have many of these lines up to migrate to DefaultConfig, it might be best to wait for that. Thoughts?

I think we would wait forever... i did some replacements and it seems to compile. Will push in a minute.

substrate/frame/support/src/traits/misc.rs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

substrate/frame/balances/src/lib.rs

franciscoaguirre · 2023-10-18T08:36:22Z

substrate/frame/balances/src/tests/mod.rs

@@ -132,9 +138,10 @@ impl Config for Test {
 	type ReserveIdentifier = TestId;
 	type WeightInfo = ();
 	type RuntimeHoldReason = TestId;
+	type RuntimeFreezeReason = RuntimeFreezeReason;


Shouldn't this be TestId?

probably me or oliver did too much copy pasta :D I will double check

actually probably not, it should be the default one.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

…k into kiz-variant-count

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

…k into kiz-variant-count

* tsv-disabling: (36 commits) Removed TODO from test-case for hard-coded delivery fee estimation (#2042) Expose collection attributes from `Inspect` trait (#1914) `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023) Sort the benchmarks before listing them (#2026) publish pallet-root-testing (#2017) Contracts: Add benchmarks to include files (#2022) Small optimisation to `--profile dev` wasm builds (#1851) basic-authorship: Improve time recording and logging (#2010) Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) [ci] Run check-rust-feature-propagation in pr and master (#2012) Improve features dev-ex (#1831) Remove obsolete comment. (#2008) Refactor candidates test in paras_inherent (#2004) PVF: Add worker check during tests and benches (#1771) Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997) polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002) Make `IdentityInfo` generic in `pallet-identity` (#1661) Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900) `CheckWeight`: Add more logging (#1996) ...

closes #1882 ## Breaking Changes This PR introduces a new item to `pallet_balances::Config`: ```diff trait Config { ++ type RuntimeFreezeReasons; } ``` This value is only used to check it against `type MaxFreeze`. A similar check has been added for `MaxHolds` against `RuntimeHoldReasons`, which is already given to `pallet_balances`. In all contexts, you should pass the real `RuntimeFreezeReasons` generated by `construct_runtime` to `type RuntimeFreezeReasons`. Passing `()` would also work, but it would imply that the runtime uses no freezes at all. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Polkadot-Forum · 2023-11-15T10:59:56Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1

…ech#1900) closes paritytech#1882 ## Breaking Changes This PR introduces a new item to `pallet_balances::Config`: ```diff trait Config { ++ type RuntimeFreezeReasons; } ``` This value is only used to check it against `type MaxFreeze`. A similar check has been added for `MaxHolds` against `RuntimeHoldReasons`, which is already given to `pallet_balances`. In all contexts, you should pass the real `RuntimeFreezeReasons` generated by `construct_runtime` to `type RuntimeFreezeReasons`. Passing `()` would also work, but it would imply that the runtime uses no freezes at all. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ensure correct variant count in Runtime[Hold/Freeze]Reason

706d5ac

kianenigma added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 17, 2023

kianenigma requested review from a team October 17, 2023 07:21

liamaharon approved these changes Oct 17, 2023

View reviewed changes

ggwpez added 3 commits October 17, 2023 12:11

Fix balances mock

88a01c4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Fix all other mocks

7fa85df

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

fmt

3a58cf2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez reviewed Oct 17, 2023

View reviewed changes

substrate/frame/support/src/traits/misc.rs Outdated Show resolved Hide resolved

set MaxHolds to 5 for kitchensink

2cd54be

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from a team October 17, 2023 10:21

ggwpez requested review from athei, acatangiu, andresilva, jsidorenko, cheme and a team as code owners October 17, 2023 10:21

gupnik approved these changes Oct 18, 2023

View reviewed changes

substrate/frame/balances/src/lib.rs Show resolved Hide resolved

franciscoaguirre reviewed Oct 18, 2023

View reviewed changes

kianenigma and others added 7 commits October 18, 2023 10:13

fix

67c624e

fix westend

50aa9e8

Fix more

0e483d5

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

fix more runtimes

4c5d0a7

more

ce34c6f

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge branch 'kiz-variant-count' of github.com:paritytech/polkadot-sd…

23055ac

…k into kiz-variant-count

Merge remote-tracking branch 'origin/master' into kiz-variant-count

0ce8932

paritytech-ci requested review from a team October 18, 2023 09:51

ggwpez and others added 2 commits October 18, 2023 12:16

Fix more

ae3fc72

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge branch 'kiz-variant-count' of github.com:paritytech/polkadot-sd…

d5d0baf

…k into kiz-variant-count

kianenigma deleted the kiz-variant-count branch October 24, 2023 10:01

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 3, 2023

adapt paritytech/polkadot-sdk#1900

a012d32

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Open

juangirini mentioned this pull request Nov 10, 2023

Ref docs for frame_currency paritytech/polkadot-sdk-docs#49

Open

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

dnjscksdn98 mentioned this pull request Jan 12, 2024

NODE-65, deps: polkadot sdk migration bifrost-platform/bifrost-node#36

Merged

13 tasks

nazar-pc mentioned this pull request Jan 18, 2024

Upgrade Substrate subspace/subspace#2424

Merged

1 task

kianenigma mentioned this pull request Mar 25, 2024

Tokens in FRAME Docs #2802

Merged

6 tasks

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024

Fix init-bridge (paritytech#1900)

2d83d63

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024

Fix init-bridge (paritytech#1900)

027555b

Dinonard mentioned this pull request Mar 28, 2024

Feat/polkadot v1.3.0 uplift AstarNetwork/Astar#1207

Merged

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Fix init-bridge (paritytech#1900)

086ca84

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Fix init-bridge (paritytech#1900)

caed583

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Fix init-bridge (paritytech#1900)

0f2bbfe

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Fix init-bridge (paritytech#1900)

4dff2e2

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024

Fix init-bridge (paritytech#1900)

532788c

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

28c7482

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

ae89548

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

9f31dc4

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

a4b45ba

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

2d961c5

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024

Fix init-bridge (paritytech#1900)

e031a92

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

Fix init-bridge (paritytech#1900)

14d563d

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024

Fix init-bridge (paritytech#1900)

2c96850

bkchr pushed a commit that referenced this pull request Apr 10, 2024

Fix init-bridge (#1900)

e7debc4

ukint-vs mentioned this pull request Apr 25, 2024

feat: Update substrate to v1.3.0 gear-tech/gear#3921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure correct variant count in `Runtime[Hold/Freeze]Reason` #1900

Ensure correct variant count in `Runtime[Hold/Freeze]Reason` #1900

kianenigma commented Oct 17, 2023 •

edited

ggwpez left a comment

franciscoaguirre Oct 18, 2023

kianenigma Oct 18, 2023

kianenigma Oct 18, 2023

Polkadot-Forum commented Nov 15, 2023

Ensure correct variant count in Runtime[Hold/Freeze]Reason #1900

Ensure correct variant count in Runtime[Hold/Freeze]Reason #1900

Conversation

kianenigma commented Oct 17, 2023 • edited

Breaking Changes

ggwpez left a comment

Choose a reason for hiding this comment

franciscoaguirre Oct 18, 2023

Choose a reason for hiding this comment

kianenigma Oct 18, 2023

Choose a reason for hiding this comment

kianenigma Oct 18, 2023

Choose a reason for hiding this comment

Polkadot-Forum commented Nov 15, 2023

Ensure correct variant count in `Runtime[Hold/Freeze]Reason` #1900

Ensure correct variant count in `Runtime[Hold/Freeze]Reason` #1900

kianenigma commented Oct 17, 2023 •

edited