Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci check for parity-publish and fix current check issues #1887

Merged
merged 37 commits into from
Oct 31, 2023
Merged

Add ci check for parity-publish and fix current check issues #1887

merged 37 commits into from
Oct 31, 2023

Conversation

Morganamilo
Copy link
Contributor

No description provided.

@Morganamilo Morganamilo added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Oct 16, 2023
@Morganamilo Morganamilo marked this pull request as ready for review October 16, 2023 14:32
@Morganamilo Morganamilo requested review from a team October 16, 2023 14:32
@Morganamilo Morganamilo requested review from a team as code owners October 16, 2023 14:32
@Morganamilo Morganamilo requested review from a team and paritytech-ci October 16, 2023 14:33
ggwpez
ggwpez approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci requires a format: bot fmt for example.

.github/workflows/check-publish.yml Outdated Show resolved Hide resolved
alvicsam
alvicsam requested changes Oct 16, 2023
View reviewed changes
.github/workflows/check-publish.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team October 16, 2023 14:37
@Morganamilo
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 16, 2023 •
edited
Loading

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 45-1a77df3d-b9b0-41d8-b5ae-42d931708ff5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 16, 2023

@Morganamilo Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

@Morganamilo Morganamilo force-pushed the morganamilo/cicheck branch 2 times, most recently from 67bcd74 to 3739f00 Compare October 17, 2023 10:32
@Morganamilo Morganamilo enabled auto-merge (squash) October 17, 2023 14:57
@paritytech-ci paritytech-ci requested a review from a team October 25, 2023 11:42
sergejparity
sergejparity approved these changes Oct 25, 2023
View reviewed changes
.github/workflows/check-publish.yml Outdated Show resolved Hide resolved
@Morganamilo
Copy link
Contributor Author

@bkchr I think we should be good to go now?

bkchr
bkchr approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving. But you need to set the licenses correctly and the renames can be reverted.

cumulus/pallets/aura-ext/Cargo.toml Outdated Show resolved Hide resolved
cumulus/pallets/dmp-queue/Cargo.toml Outdated Show resolved Hide resolved
cumulus/pallets/parachain-system/Cargo.toml Outdated Show resolved Hide resolved
cumulus/pallets/xcmp-queue/Cargo.toml Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-polkadot/Cargo.toml Show resolved Hide resolved
cumulus/test/relay-sproof-builder/Cargo.toml Outdated Show resolved Hide resolved
substrate/bin/node/inspect/Cargo.toml Show resolved Hide resolved
cumulus/client/service/Cargo.toml Show resolved Hide resolved
@Morganamilo
Copy link
Contributor Author

@bkchr what should the licence be for minimal-runtime (substrate/bin/minimal/runtime)?

@Morganamilo Morganamilo merged commit 495d24d into master Oct 31, 2023
102 of 111 checks passed
@Morganamilo Morganamilo deleted the morganamilo/cicheck branch October 31, 2023 18:04
EgorPopelyaev pushed a commit that referenced this pull request Nov 3, 2023
@Morganamilo @sergejparity
@bkchr @EgorPopelyaev
Add ci check for parity-publish and fix current check issues (#1887)
33f7987 
Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
@EgorPopelyaev EgorPopelyaev mentioned this pull request Nov 6, 2023
Merged
acatangiu added a commit that referenced this pull request Nov 6, 2023
@EgorPopelyaev @bkontur
@Morganamilo @sergejparity @bkchr @serban300 @acatangiu @joepetrowski @svyatonik
Backport missing functionalities for cumulus (#2176)
e990078 
This PR backports missing PR's needed for 1.3.0 cumulus release:
#2042
#2139
#2129
#1967
#2021
#1887
#2023

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Lulu <morgan@parity.io>
Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@Morganamilo @sergejparity @bkchr
Add ci check for parity-publish and fix current check issues (parityt…
d56129e 
…ech#1887)

Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@svyatonik
optimize justification before submit (paritytech#1887)
131b173 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@svyatonik
optimize justification before submit (paritytech#1887)
3985977 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik
optimize justification before submit (paritytech#1887)
f652269 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
4686068 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
251dc70 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
7d13c06 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
163dc5d 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
67f1093 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
1b841c6 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
127b8a3 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
b76c6df 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
59d2e42 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
227d56c 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
ea289d4 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
optimize justification before submit (paritytech#1887)
e0c4516 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
optimize justification before submit (#1887)
1d6e8a9 
* optimize justification before submit

* fmt

* spelling

* clippy

* fmt again

* aaand compilation

* clippy
@enddynayn
Copy link

why was the package renamed to staging-parachain-info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma left review comments

@bkchr bkchr bkchr approved these changes

@sergejparity sergejparity sergejparity approved these changes

@chevdor chevdor chevdor approved these changes

@mrcnski mrcnski mrcnski approved these changes

@coderobe coderobe coderobe approved these changes

@alvicsam alvicsam alvicsam approved these changes

@paritytech-ci paritytech-ci Awaiting requested review from paritytech-ci

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Morganamilo @ggwpez @enddynayn @chevdor @kianenigma @bkchr @mrcnski @coderobe @alvicsam @sergejparity