sc-informant: Respect --disable-log-color
#3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `sc-informant` to respect the `--disable-log-color` CLI flag.
michalkucharczyk
approved these changes
Jan 22, 2024
davxy
approved these changes
Jan 22, 2024
| @@ -39,7 +39,7 @@ fn interval(duration: Duration) -> impl Stream<Item = ()> + Unpin { | |||
| /// The format to print telemetry output in. | |||
There was a problem hiding this comment.
Probably this doc should be changed.
By definition telemetry is collection of remote information, but here we are displaying info coming from local node.
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Changes `sc-informant` to respect the `--disable-log-color` CLI flag. Closes: paritytech#2795 --------- Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sc-informantto respect the--disable-log-colorCLI flag.Closes: #2795