-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-xcm] Adjust benchmarks (teleport_assets/reserve_transfer_assets) not relying on ED #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts) not relying on ED
8 tasks
franciscoaguirre
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
acatangiu
approved these changes
Feb 26, 2024
acatangiu
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ts) not relying on ED (patch for 1.7.0) (#3465) For description, please see: #3464 Expected patches for (1.6.0): - cumulus-pallet-parachain-system `0.8.1` - cumulus-primitives-utility `0.8.1` - polkadot-runtime-common `8.0.1` - pallet-xcm-benchmarks `8.0.2` - pallet-xcm `8.0.0` - staging-xcm-builder `8.0.0` --------- Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
ordian
added a commit
that referenced
this pull request
Feb 28, 2024
…head-data * origin/master: (51 commits) Runtime Upgrade ref docs and Single Block Migration example pallet (#1554) Collator overseer builder unification (#3335) Introduce storage attr macro `#[disable_try_decode_storage]` and set it on `System::Events` and `ParachainSystem::HostConfiguration` (#3454) Add Polkadotters bootnoders per IBP application (#3423) Add documentation around FRAME Origin (#3362) Bridge zombienet tests: Check amount received at destination (#3490) Snowbridge benchmark tests fix (#3424) fix(zombienet): increase timeout in download artifacts (#3376) Cleanup String::from_utf8 (#3446) [prdoc] Validate crate names (#3467) Limit max execution time for `test-linux-stable` CI jobs (#3483) Introduce Notification block pinning limit (#2935) frame-support: Improve error reporting when having too many pallets (#3478) add Encointer as trusted teleporter for Westend (#3411) [pallet-xcm] Adjust benchmarks (teleport_assets/reserve_transfer_assets) not relying on ED (#3464) Add more debug logs to understand if statement-distribution misbehaving (#3419) Remove redundant parachains assigner pallet. (#3457) Use generic hash for runtime wasm in resolve_state_version_from_wasm (#3447) Runtime: allow backing multiple candidates of same parachain on different cores (#3231) Bridge zombienet tests: move all "framework" files under one folder (#3462) ...
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During the bumping of the
polkadot-fellows
repository topolkadot-sdk@1.6.0
, I encountered a situation where the benchmarksteleport_assets
andreserve_transfer_assets
in AssetHubKusama started to fail. This issue arose due to a decreased ED balance for AssetHubs introduced here, and also because of a missing CI pipeline to check the benchmarks, which went unnoticed.These benchmarks expect the
caller
to have enough:So the initial balance was calculated as
ED * 100
, which seems reasonable:The problem arises when the price for delivery is 100 times higher than the existential deposit. In other words, when
ED * 100
does not coverBTT
+BFPD
.I check AHR/AHW/AHK/AHP and this problem has only AssetHubKusama
which results in the error;
Solution
The benchmarks
teleport_assets
andreserve_transfer_assets
were fixed by removingED * 100
and replacing it withDeliveryHelper
logic, which calculates the (almost real) price for delivery and sets it along with the existential deposit as the initial balance for the account used in the benchmark.TODO
release-crates-io-v1.8.0