stake-tracker feedback PR

[gpestana]

• Changes the target list score type from balance to u128 (ExtendedBalance)
  • simplifies balance/ vote_weight/ extended_balance conversions
  • relies less on the currency total issuance call
  • ensures approval stake calculations/storage is safe
• Simplifies stake tracker logic
  • removes a few redundant checks
  • split on_stake_update code
• Ensures VoterUpdateMode is taken into consideration in try-state checks
  • use voter mode lazy in benchmarks
  • update weights + check the diff with voter lazy
• Docs improvements
• All tests passing after merging validator disabling and virtual stakers

new

• ensures duplicate nominations are dedup before calculating the approvals stake
• chills nominator after total slash to ensure the target can be reaped/kill without leaving nominations behind.
• ensures that switching from validator to nominator and back is correct
  • a nominator may have an entry in the targetlist (if it was a validator + has nominations)
  • ensure target node is removed if balance is 0 and it is a nominator.
  • addresses https://github.com/paritytech-secops/srlabs_findings/issues/383

---

Other experiments: (not included)

• Wraps account and staking state in who for OnStakingUpdate methods #4402 (passing the status of the staker with who in the OnStakingUpdate interface is less clean, it turns out)
• Change sorted list types and simplify type conversions in stake-tracker #4361

[gpestana]

bot bench substrate-pallet --pallet=pallet_staking

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6161496 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-6e8d8d4d-a8e7-4c1b-b331-7cdbe4e6ccf0 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6161496 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6161496/artifacts/download.

[gpestana]

bot bench substrate-pallet --pallet=pallet_staking

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6162598 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-82109c79-e83d-4168-927d-d643f6aa4301 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6162598 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6162598/artifacts/download.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6170835